Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trip-updates-for-agency API endpoint of onebusaway-api-webapp does not include stop sequence in stop time updates #341

Open
jamespizzurro opened this issue May 19, 2023 · 1 comment

Comments

@jamespizzurro
Copy link

As of today, the trip updates returned by the trip-updates-for-agency API endpoint of onebusaway-api-webapp look something like this:

  {
    trip {
      trip_id: "10820533__KPOB-CS:221:0:Weekday:1:23MAR:85028:12345"
      route_id: "513"
    }
    stop_time_update {
      arrival {
        time: 1684511491
      }
      departure {
        time: 1684511491
      }
      stop_id: "16380"
    }
    stop_time_update {
      arrival {
        time: 1684511911
      }
      departure {
        time: 1684511911
      }
      stop_id: "2766"
    }
    stop_time_update {
      arrival {
        time: 1684512211
      }
      departure {
        time: 1684512211
      }
      stop_id: "2114"
    }
    stop_time_update {
      arrival {
        time: 1684512631
      }
      departure {
        time: 1684512631
      }
      stop_id: "2164"
    }
    stop_time_update {
      arrival {
        time: 1684513351
      }
      departure {
        time: 1684513351
      }
      stop_id: "2869"
    }
    stop_time_update {
      arrival {
        time: 1684513929
      }
      departure {
        time: 1684513929
      }
      stop_id: "3219"
    }
    stop_time_update {
      arrival {
        time: 1684513951
      }
      departure {
        time: 1684513951
      }
      stop_id: "2861"
    }
    vehicle {
      id: "KPOB-CS:221:0:Weekday:1:23MAR:85028:12345"
    }
    timestamp: 1684511203
    delay: 151
  }

Note that all the stop time update entities are lacking a stop_sequence field despite that information seemingly being readily available so long as timepoint predictions are enabled. It would be great if these could be added given there doesn't appear to be any technical limitation in OneBusAway that would explain why they're not included.

jamespizzurro added a commit to jamespizzurro/onebusaway-application-modules that referenced this issue May 19, 2023
…me updates returned by trip-updates-for-agency API endpoint of onebusaway-api-webapp
@jamespizzurro
Copy link
Author

I went ahead and opened a new pull request (#342) for what I believe is just a one-line change. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant