Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules matching other modules' components with same names #4

Open
opr opened this issue Dec 28, 2019 · 1 comment
Open

Modules matching other modules' components with same names #4

opr opened this issue Dec 28, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@opr
Copy link
Contributor

opr commented Dec 28, 2019

Hi, if I have a module container

@include module(container) {
  background: red;
}

and then another module hero

@include module(hero) {

  @include component(background-container) {

    @include is(desktop) {
      margin: 10px auto;
    }
  }
}

the generated CSS:

.container, [class*=container--] {
    background: red;
}

also affects my div named thus: <div class="hero__background-container--desktop">

@opr
Copy link
Contributor Author

opr commented Dec 28, 2019

Comment from Raptori on the reactiflux discord

[class^="container-"], [class*=" container-"] might work?

@esr360 esr360 added the enhancement New feature or request label Jan 25, 2020
@esr360 esr360 self-assigned this Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants