New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting luaqrcode and proposing a rockspec #1

Open

1 of 2 tasks

Omikhleia opened this issue Dec 9, 2022 · 1 comment

Owner

Omikhleia commented Dec 9, 2022 •

edited

Just noted here in passing, for the reminder. Should make a PR.

There are some minor syntax issues in luaqrcode, e.g.
- Line 546 assert(false,"Unknown type for data: %s",type(data)) -- assert() expects 2 arguments, not 3.
- Line 1133 positions,x,y,dir = get_next_free_positions(matrix,x,y,dir,byte,mask) -- function has 5 arguments.
The library doesn't have a rockspec / isn't published on luarocks. Doing so would avoid our "copying of it locally here, or using a submodule, etc.

The text was updated successfully, but these errors were encountered:

Owner Author

Omikhleia commented Dec 10, 2022

Linting proposed upstream here speedata/luaqrcode#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment