Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no chance to add a new line with one change #671

Open
sarzaminonline opened this issue Mar 17, 2023 · 23 comments
Open

no chance to add a new line with one change #671

sarzaminonline opened this issue Mar 17, 2023 · 23 comments

Comments

@sarzaminonline
Copy link
Contributor

there is no chance to add only one line, when you do add a line, system detects 3 changes, one line deleted, then added along with my new line
why is that?
would you please fix this?
image

@bybrl
Copy link
Contributor

bybrl commented Mar 20, 2023

I'm not sure, they don't seem to care that much as there are so many failed pull requests due to this. I don't know if the devs care anymore. I've also been at this point for more than 2 days. I'm trying to find a loophole that allows us to add. Edit: Making a post on StackOverflow about the problem.

@ajweitz
Copy link
Contributor

ajweitz commented Mar 27, 2023

same here

@bybrl
Copy link
Contributor

bybrl commented Mar 27, 2023

Ok. I've figured out the problem. If you open one of the zone files in GitHub.dev, you can add after the comments. Don't add at the end of the file or it will fail that check again. There was no repository problems, only a slight misunderstanding.

@ArtieFuzzz
Copy link
Collaborator

ArtieFuzzz commented Mar 28, 2023

Although I'm able to edit Pull Requests (attach labels, etc.) I cannot merge them since I do not have Write access to this repo. @politician has replied to a Pull Request mentioning that he is moving houses, since then, hasn't had much activity since.

I've tried helping people but I don't have the motivation to continue.

@py660
Copy link
Contributor

py660 commented Mar 29, 2023

Try using github.dev and editing there, it seems to solve the problem for me.

@pepa65
Copy link
Contributor

pepa65 commented Mar 29, 2023

What if that file did have a newline at the end, wouldn't that solve everyone's issue? Why doesn't someone authorized add a newline??

@bybrl
Copy link
Contributor

bybrl commented Mar 29, 2023 via email

@pepa65
Copy link
Contributor

pepa65 commented Mar 29, 2023

OK, I have to say the github.dev editor is accessible right from the Edit menu. If you click on the down-arrow to the right of the pencil icon, you can choose github.dev and apparently it allows the file to be saved without a final newline..!

@pepa65
Copy link
Contributor

pepa65 commented Mar 29, 2023

I'm pretty sure that the hcl/sh code would be interfered with if there was a newline at the end of the file.

I'm sure the code could be fixed to deal with that!

@KUKHUA
Copy link
Contributor

KUKHUA commented May 15, 2023

I'm not sure, they don't seem to care that much as there are so many failed pull requests due to this. I don't know if the devs care anymore. I've also been at this point for more than 2 days. I'm trying to find a loophole that allows us to add. Edit: Making a post on StackOverflow about the problem.

There is a solution? all u need to do is go to the 2nd to last one then press enter & fill it out

@bybrl
Copy link
Contributor

bybrl commented May 15, 2023 via email

@Polkastop
Copy link

hi, im struggling with this too.

Ive tried second to last line, tried doing it in gihub.dev and still end up changing 2 lines.

im trying to add poli99 with [ns1.afraid.org, ns2.afraid.org, ns3.afraid.org, ns4.afraid.org] # Register poli99.wip.la

but it fails, is there another method please.

thanks Ian (complete newbie to github)

@santydesignscr
Copy link
Contributor

I created a website to auto register domains: test.bytewave.wip.la (is beta, but working)

@pepa65
Copy link
Contributor

pepa65 commented Dec 28, 2023

I created a website to auto register domains: test.bytewave.wip.la (is beta, but working)

You have to sign up??

@santydesignscr
Copy link
Contributor

Yes, its only to recieve the renew remider that the system sends

@santydesignscr
Copy link
Contributor

But username and age you can use any random, the age is not needed and is requested only because I recycled the code of another project

@pepa65
Copy link
Contributor

pepa65 commented Dec 28, 2023

Just tried it, and the page lists the domain I registered with the Nameservers, but the file zones/wip.la.yaml was not updated. Do you batch update?

@santydesignscr
Copy link
Contributor

Your NS is invalid, there is a point in the end of each one, try again without it

@santydesignscr
Copy link
Contributor

Screenshot_2023-12-28-01-50-18-301_com android chrome

@santydesignscr
Copy link
Contributor

The PR was rejected by the test and closed by my website

@pepa65
Copy link
Contributor

pepa65 commented Dec 28, 2023

Hmm. We’re having trouble finding that site.
We can’t connect to the server at register.bytewave.wip.la.

@santydesignscr
Copy link
Contributor

test.bytewave.wip.la

@santydesignscr
Copy link
Contributor

Hello everyone, it seems that this subdomain is not currently working, I recommend this platform that I just launched, the subdomain is webcr.top, apparently there are almost no subdomains, in my plataform you can register a subdomain, edit NS:
https://nic.webcr.top/app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants