Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify code generation for the new never type #729

Open
Ocramius opened this issue Dec 7, 2021 · 1 comment · May be fixed by #735
Open

Verify code generation for the new never type #729

Ocramius opened this issue Dec 7, 2021 · 1 comment · May be fixed by #735
Milestone

Comments

@Ocramius
Copy link
Owner

Ocramius commented Dec 7, 2021

The test suite includes scenarios that handle the : void return type of methods:

We need:

  1. similar classes, but using the never type ( https://wiki.php.net/rfc/noreturn_type )
  2. make sure we find usages of above classes, and introduce tests around the never type wherever they are used (using the newly introduced assets)
@Ocramius Ocramius added this to the 2.14.0 milestone Dec 7, 2021
@Ocramius
Copy link
Owner Author

Ocramius commented Dec 7, 2021

Note: this may be an absolute beast to handle, because we need to get rid of most generated return; statements from proxies.

@alekitto alekitto linked a pull request Feb 18, 2022 that will close this issue
@Ocramius Ocramius modified the milestones: 2.14.0, 2.15.0 Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant