Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(French Translation): French Translation for the 2023 edition #130

Merged
merged 13 commits into from
Jun 3, 2024
Merged

(French Translation): French Translation for the 2023 edition #130

merged 13 commits into from
Jun 3, 2024

Conversation

Nounoursdestavernes
Copy link
Contributor

Hello there,

This is my PR for the french translation. (#129)

Let me know if you want any changes.
Best regards,
NounoursDesTavernes / Aurélien TRONCY.

@Nounoursdestavernes Nounoursdestavernes changed the base branch from master to develop April 4, 2024 08:17
llegaz
llegaz reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@llegaz llegaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass on my review for this french translation.

editions/2023/fr/0x04-release-notes.md Outdated Show resolved Hide resolved
editions/2023/fr/0x11-t10.md Outdated Show resolved Hide resolved
editions/2023/fr/0x11-t10.md Outdated Show resolved Hide resolved
editions/2023/fr/0xa5-broken-function-level-authorization.md Outdated Show resolved Hide resolved
editions/2023/fr/0xa5-broken-function-level-authorization.md Outdated Show resolved Hide resolved
editions/2023/fr/0xa6-unrestricted-access-to-sensitive-business-flows.md Outdated Show resolved Hide resolved
editions/2023/fr/0xa6-unrestricted-access-to-sensitive-business-flows.md Show resolved Hide resolved
editions/2023/fr/0xa6-unrestricted-access-to-sensitive-business-flows.md Show resolved Hide resolved
editions/2023/fr/0xa7-server-side-request-forgery.md Outdated Show resolved Hide resolved
editions/2023/fr/0xa7-server-side-request-forgery.md Outdated Show resolved Hide resolved
@llegaz
Copy link
Contributor

llegaz commented Apr 5, 2024

I will try to finish my review as soon as possible.

@Nounoursdestavernes Good work btw and thank you for your contribution.

@Nounoursdestavernes
Copy link
Contributor Author

Nounoursdestavernes commented Apr 5, 2024 •
edited

Thx for the review @llegaz I made the modifications :)

It's my first contribution to an Open Source project and first translation it was not as easy as I thought so I thank you a lot for your help ;)

I will be happy to continue to improve the quality of the translation if you have any changes to suggest

@ErezYalon ErezYalon linked an issue Apr 10, 2024 that may be closed by this pull request
Translation to French (fr) for 2023 version #129
Closed
@Nounoursdestavernes
Copy link
Contributor Author

Hi everyone,
I hope you're doing well.

Do you have any update about my last commentaries @llegaz ?

I was wondering if you had the time to consider them.

llegaz
llegaz reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@llegaz llegaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finished to review this translation for the 2023 edition.

Except for the few suggestions everything is good to go on my side :)

editions/2023/fr/0xa8-security-misconfiguration.md Outdated Show resolved Hide resolved
editions/2023/fr/0xa9-improper-inventory-management.md Outdated Show resolved Hide resolved
editions/2023/fr/0xa9-improper-inventory-management.md Outdated Show resolved Hide resolved
editions/2023/fr/0xa9-improper-inventory-management.md Outdated Show resolved Hide resolved
editions/2023/fr/0xaa-unsafe-consumption-of-apis.md Outdated Show resolved Hide resolved
editions/2023/fr/0xaa-unsafe-consumption-of-apis.md Outdated Show resolved Hide resolved
editions/2023/fr/0xaa-unsafe-consumption-of-apis.md Outdated Show resolved Hide resolved
editions/2023/fr/0xaa-unsafe-consumption-of-apis.md Outdated Show resolved Hide resolved
editions/2023/fr/0xb1-next-devsecops.md Outdated Show resolved Hide resolved
@PauloASilva
Copy link
Collaborator

Hi @Nounoursdestavernes
Can you please confirm whether all changes were applied and this is the final version?

I'll need a few days to work on this to make sure everything works as expected after merging.

Nounoursdestavernes and others added 9 commits April 24, 2024 19:51
@Nounoursdestavernes @llegaz
Update editions/2023/fr/0xa8-security-misconfiguration.md
59ea51c 
Correction of some translation mistake

Co-authored-by: Laurent Legaz <[email protected]>
@Nounoursdestavernes @llegaz
Update editions/2023/fr/0xa9-improper-inventory-management.md
77a26a4 
Co-authored-by: Laurent Legaz <[email protected]>
@Nounoursdestavernes @llegaz
Update editions/2023/fr/0xa9-improper-inventory-management.md
aedf822 
Co-authored-by: Laurent Legaz <[email protected]>
@Nounoursdestavernes @llegaz
Update editions/2023/fr/0xa9-improper-inventory-management.md
46e0544 
Co-authored-by: Laurent Legaz <[email protected]>
@Nounoursdestavernes @llegaz
Update editions/2023/fr/0xaa-unsafe-consumption-of-apis.md
47d18ba 
Co-authored-by: Laurent Legaz <[email protected]>
@Nounoursdestavernes @llegaz
Update editions/2023/fr/0xb1-next-devsecops.md
9536bed 
Co-authored-by: Laurent Legaz <[email protected]>
@Nounoursdestavernes @llegaz
Update editions/2023/fr/0xaa-unsafe-consumption-of-apis.md
203757a 
Co-authored-by: Laurent Legaz <[email protected]>
@Nounoursdestavernes @llegaz
Update editions/2023/fr/0xaa-unsafe-consumption-of-apis.md
4cad288 
Co-authored-by: Laurent Legaz <[email protected]>
@Nounoursdestavernes @llegaz
Update editions/2023/fr/0xaa-unsafe-consumption-of-apis.md
57da7e7 
Co-authored-by: Laurent Legaz <[email protected]>
@Nounoursdestavernes
Copy link
Contributor Author

Hi @PauloASilva
Yes everything is good and this is the final version !

Thanks a lot @llegaz for your review :)

@llegaz
Copy link
Contributor

llegaz commented Apr 27, 2024

You are very welcome @Nounoursdestavernes thanks again for your work.

@Nounoursdestavernes
Copy link
Contributor Author

Hi there,

Is everything okay ? Should I make any changes to the PR ? @PauloASilva

Best regards,
NounoursDesTavernes / Aurélien TRONCY.

@PauloASilva
Copy link
Collaborator

Is everything okay ? Should I make any changes to the PR ? @PauloASilva

I didn't find the time yet to review the PR (make sure everything works properly).
I should be able to do it soon.

@PauloASilva PauloASilva merged commit 1724508 into OWASP:develop Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llegaz llegaz llegaz left review comments

Assignees

@PauloASilva PauloASilva

Labels
2023 translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation to French (fr) for 2023 version
4 participants
@Nounoursdestavernes @llegaz @PauloASilva @ErezYalon