Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "fork me on github" ribbon #11

Open
kaivalyar opened this issue Jan 27, 2017 · 7 comments
Open

Add a "fork me on github" ribbon #11

kaivalyar opened this issue Jan 27, 2017 · 7 comments
Assignees
@kaivalyar

Comments

@kaivalyar
Copy link
Member

No description provided.

@kaivalyar kaivalyar self-assigned this Jan 27, 2017
@kaivalyar
Copy link
Member Author

I have submitted a pr - somebody please review ...
taken from here: https://simonwhitaker.github.io/github-fork-ribbon-css/

@0xRampey
Copy link
Member

@kaivalyar Looks fine. Can you make it black and comment out the underlying button?

@0xRampey
Copy link
Member

#10

@kaivalyar
Copy link
Member Author

@prampey i'm unsure of the encore workflow - how to i see my changes? (I made the previous commit blindly - without actually seeing the effects my code was having)

@SebastinSanty
Copy link
Member

I think that the README.md is enough for installation. Just make sure you have node and npm installed.

@kaivalyar
Copy link
Member Author

yeah well, but do i need to install it just to fix the ribbon?!

@SebastinSanty
Copy link
Member

Yes you would have to. Would help in further contributions too.

@kaivalyar kaivalyar added the Easy label Apr 14, 2017
@SebastinSanty SebastinSanty removed the Easy label Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaivalyar kaivalyar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xRampey @kaivalyar @SebastinSanty