Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS 10.15+ Support #45

Open
manngo opened this issue Oct 8, 2019 · 40 comments
Open

macOS 10.15+ Support #45

manngo opened this issue Oct 8, 2019 · 40 comments
Labels
status: Abandoned Will not be fixed

Comments

@manngo
Copy link

manngo commented Oct 8, 2019

I have tried this on two machines with a freshly install MacOS 10.15 Catalina. It doesn’t appear to be working.

@Nyx0uf
Copy link
Owner

Nyx0uf commented Oct 9, 2019

I don't plan on installing catalina any time soon, so either someone find the cause why it's not working or you'll have to wait.

@manngo
Copy link
Author

manngo commented Oct 9, 2019

As far as I can tell, it must be a 32bit application which no longer works in Catalina. I don’t know whether it would be a matter of recompiling.

@Nyx0uf
Copy link
Owner

Nyx0uf commented Oct 9, 2019

Nonsense, this plugin has been 64-bit only since the beginning.

@jeffbyrnes
Copy link

jeffbyrnes commented Oct 9, 2019

This issue is that this and other QL plugins are no longer recognized as created by an identified developer due to notarization enforcement. The binary needs to be notarized by Apple, which needs a Developer Apple ID and Xcode.

Here are the docs on Notarizing Your App Before Distribution.

@Nyx0uf
Copy link
Owner

Nyx0uf commented Oct 9, 2019

I don't want to waste the little time I have with this kind of bullshit. With 900+ stars & 50 forks on this repo it should not be too hard to find someone to do it.

@rurza
Copy link

rurza commented Oct 28, 2019

I don't want to waste the little time I have with this kind of bullshit. With 900+ stars & 50 forks on this repo it should not be too hard to find someone to do it.

Then it will require the pull request every time you want to release a new version.

@sbarex
Copy link

sbarex commented Oct 30, 2019

Has anyone tried to see if it works on 10.15.1?
I updated my virtual machine and it seems that now the various qlgenerators works but I'm not sure if I did something strange in the settings or if it's a problem solved in the last update.

@setanarut
Copy link

The title bar does not provide information except these two formats; WebP, BPG
macOS Catalina 10.15.1

@sbarex
Copy link

sbarex commented Oct 30, 2019

I think that macos don't allow to customize the quicklook for some common file formats like jpg, png… so for these files is used the standard generator, for less common format (like webp) is used the custom generator.

@setanarut
Copy link

setanarut commented Oct 30, 2019

I think that macos don't allow to customize the quicklook for some common file formats like jpg, png… so for these files is used the standard generator, for less common format (like webp) is used the custom generator.

duplicate #44

@setanarut
Copy link

The system prefers the public.image identifier.

/System/Library/QuickLook/Image.qlgenerator/Contents/Info.plist

<key>CFBundleTypeRole</key>
            <string>QLGenerator</string>
            <key>LSItemContentTypes</key>
            <array>
                <string>public.image</string>
            </array>

@RomanSmolka
Copy link

The system prefers the public.image identifier.

/System/Library/QuickLook/Image.qlgenerator/Contents/Info.plist

<key>CFBundleTypeRole</key>
            <string>QLGenerator</string>
            <key>LSItemContentTypes</key>
            <array>
                <string>public.image</string>
            </array>

I just tried moving /System/Library/QuickLook/Image.qlgenerator somewhere else to see if it makes any difference. To my surprise, quick looking images still works the same. Looks like ql for images works somewhat different in Catalina...

@manngo
Copy link
Author

manngo commented Nov 5, 2019

The system prefers the public.image identifier.
/System/Library/QuickLook/Image.qlgenerator/Contents/Info.plist

<key>CFBundleTypeRole</key>
            <string>QLGenerator</string>
            <key>LSItemContentTypes</key>
            <array>
                <string>public.image</string>
            </array>

I just tried moving /System/Library/QuickLook/Image.qlgenerator somewhere else to see if it makes any difference. To my surprise, quick looking images still works the same. Looks like ql for images works somewhat different in Catalina...

How did you move it? I tried it myself and the system won’t let me.

@RomanSmolka
Copy link

How did you move it? I tried it myself and the system won’t let me.

You need to re-mount the system partition as writable with sudo mount -uw /. Then use mv with sudo.

@manngo
Copy link
Author

manngo commented Nov 5, 2019

Ah. I forgot about about the new partitioning system for Catalina.

@setanarut
Copy link

setanarut commented Nov 5, 2019

@RomanSmolka I wonder if changing the file extension will give the same result. maybe changing the file location is ineffective. you can back up the file by compressing it. if the generator is not used. why there? interesting.

@sbarex
Copy link

sbarex commented Nov 5, 2019

I just tried moving /System/Library/QuickLook/Image.qlgenerator somewhere else to see if it makes any difference. To my surprise, quick looking images still works the same. Looks like ql for images works somewhat different in Catalina...

after moving the generator do you have reset quicklook with qlmanage -r? and after try to view an image that you don't have opened recenty to be sure it's not in the cache.

@RomanSmolka
Copy link

after moving the generator do you have reset quicklook with qlmanage -r? and after try to view an image that you don't have opened recenty to be sure it's not in the cache.

Yes, it's still the same even after reboot.

@skynet01
Copy link

skynet01 commented Nov 5, 2019

So what you are saying is that you can make this extension work by deleting the default image preview in Catalina? Do you still have the new Catalina controls like the rotate and markup button?

@setanarut
Copy link

Someone who understands Catalina should write a new plugin. All we need is to show the title bar information. WebP is not required. the system's own generator should be used. I lost a feature that was very useful to me and loved.

@skynet01
Copy link

skynet01 commented Nov 5, 2019

I think someone can just fork the current one and fix it. :)

@RomanSmolka
Copy link

@skynet01 No, that doesn't make it work. There is actually no difference whether the image generator is present or not, which leads me to a thought that in Catalina, image QL is not generated by an extension. Maybe they did it to support the new features you mentioned. But I might be wrong.

@hamiltont
Copy link

Regarding this:

This issue is that this and other QL plugins are no longer recognized as created by an identified developer due to notarization enforcement. The binary needs to be notarized by Apple, which needs a Developer Apple ID and Xcode.

You can disable gatekeeper by opening a terminal and running this. After doing this, qlImage runs OK on Catalina for webp files (the system generator is still used for all other image types)

$ xattr -d -r com.apple.quarantine ~/Library/QuickLook/qlImageSize.qlgenerator/

As an FYI, homebrew-cask team is currently frustrated by gatekeeper on Catalina, it's breaking many useful-but-small-audience utilities. See Homebrew/homebrew-cask#70798 for a more in depth discussion.

I did try to debug the public.image issue, got as far as this line but it still seems to render preview without the sizes in the title bar. Output does claim it's using the qlImageSize generator - perhaps someone with more experience in QL can spot an error I've made here:

$ qlmanage -p -g ~/Library/QuickLook/qlImageSize.qlgenerator -c jpg ~/Downloads/medium.jpg

@ChesterYue
Copy link

ChesterYue commented Apr 8, 2020

Reason:

This issue is actually caused by the macOS 10.15.4 won't call the function QuickLookGeneratorPluginFactory of custom plugin which is not same as the macOS 10.14.6;

Detail:

How I debug with this project by the steps:

  1. git clone https://github.com/Nyx0uf/qlImageSize.git
  2. cd qlImageSize
  3. tar xJvf images-samples.txz (decompress sample image in the project)
  4. open qlImageSize.xcodeproj
  5. Xcode top menu: Product -> Scheme -> Edit Scheme
    • Info -> Executable -> Other -> cmd + shift + g -> /usr/bin/qlmanage
      1
    • Arguments:
      3
      [A] copy from
      3
      [B] copy result from terminal: realpath Users/benjamin/btsync/projects/qlImageSize/images-samples/webp.webp
      [C] webp
    • close
  6. add breakpoint in QuickLookGeneratorPluginFactory of main.m
    4
  7. Xcode top menu: Product - Run, break point is hit with webp on macOS 10.15.4 (if not, try to restart Xcode, god bless Apple)
  8. but if replace webp to png, the break point is not hit with png on macOS 10.15.4.:
    • replace [B] with result from terminal realpath Users/benjamin/btsync/projects/qlImageSize/images-samples/png.png
    • replace [C] with png
      5
    • after run project, the break point is not hit with png on macOS 10.15.4.
  9. but repeating the same steps wrote above on macOS 10.14.6, I find the break point is hit with both webp and png on macOS 10.14.6. It works well.

Conclusion until now:

As sabrex wrote the macOS 10.15.4 is not calling the custom quick look plugin with the common image file type such as png / jpg.

macOS 10.14.6 macOS 10.15.4
webp
png

PS:

As hazarek wrote I love this handy feature too. Sadly I can't fix it so far. If anyone have any thought, please leave a comment. 😭😭😭

@sbarex
Copy link

sbarex commented Apr 8, 2020

I have pull a request of info about this behavios to the apple support about october 2019, but without any response.

@ChesterYue
Copy link

I have pull a request of info about this behavios to the apple support about october 2019, but without any response.

As Xcode(11.4) is not able to create QuickLook project already (since some Xcode version before), I think Apple is going to be disregard for maintaining the QuickLook development. 🙁🙁🙁

@setanarut
Copy link

I have pull a request of info about this behavios to the apple support about october 2019, but without any response.

As Xcode(11.4) is not able to create QuickLook project already (since some Xcode version before), I think Apple is going to be disregard for maintaining the QuickLook development. 🙁🙁🙁

So does it mean it is impossible to show Quicklook title bar information?

@ChesterYue
Copy link

I have pull a request of info about this behavios to the apple support about october 2019, but without any response.

As Xcode(11.4) is not able to create QuickLook project already (since some Xcode version before), I think Apple is going to be disregard for maintaining the QuickLook development. 🙁🙁🙁

So does it mean it is impossible to show Quicklook title bar information?

I think so with the information i got as so far.

@setanarut
Copy link

I have pull a request of info about this behavios to the apple support about october 2019, but without any response.

As Xcode(11.4) is not able to create QuickLook project already (since some Xcode version before), I think Apple is going to be disregard for maintaining the QuickLook development. 🙁🙁🙁

So does it mean it is impossible to show Quicklook title bar information?

I think so with the information i got as so far.

But sbarex's plugin can modify the quicklook window (right click, cursor selection). I'm just thinking. i'm not a Apple developer.

@ChesterYue
Copy link

I have pull a request of info about this behavios to the apple support about october 2019, but without any response.

As Xcode(11.4) is not able to create QuickLook project already (since some Xcode version before), I think Apple is going to be disregard for maintaining the QuickLook development. 🙁🙁🙁

So does it mean it is impossible to show Quicklook title bar information?

I think so with the information i got as so far.

But sbarex's plugin can modify the quicklook window (right click, cursor selection). I'm just thinking. i'm not a Apple developer.

It's not about the ability to modify window, the key point is the common image file type (png) which is not support to using customized plugin. I think sbarex knows what's going on.

@sbarex
Copy link

sbarex commented Apr 8, 2020

The new appex extension is the replacement for the old quicklook generator. It's allow more customization of the interface (not the title bar, but you can insert a label where you want inside the window) but, like custom generator, it cannot handle many file standard format reserverd by the OS. Sorry but Apple has taken a step back.

@ChesterYue
Copy link

ChesterYue commented Apr 8, 2020

The new appex extension is the replacement for the old quicklook generator. It's allow more customization of the interface (not the title bar, but you can insert a label where you want inside the window) but, like custom generator, it cannot handle many file standard format reserverd by the OS. Sorry but Apple has taken a step back.

See it, let me study this tomorrow!

@ChesterYue
Copy link

run:
qlmanage -m
result:
public.image -> /System/Library/QuickLook/Image.qlgenerator (906.2)

try:
sudo mv /System/Library/QuickLook/Image.qlgenerator ~/Desktop
qlmanage -r; qlmanage -m;
result:
public.image -> /Users/xxx/Library/QuickLook/qlImageSize.qlgenerator (2.6.1)

but still not working.

@Sponge-bink
Copy link

  1. Xcode top menu: Product - Run, break point is hit with webp on macOS 10.15.4 (if not, try to restart Xcode, god bless Apple)
  2. but if replace webp to png, the break point is not hit with png on macOS 10.15.4.:

I did exactly the same on Xcode 11.6 macOS 10.15.5, and get the exactly same result. The resolution info showed on the preview of the webp file but not on the png one.

@strafe
Copy link

strafe commented Aug 26, 2020

@ChesterYue have you had chance to see if Big Sur changes this behaviour back?

@sbarex
Copy link

sbarex commented Sep 3, 2020

For Catalina (and Big Sur) I created a Finder Sync extension to see the image resolution (and also some other info) inside the contextual menu. It also support movie and audio files.
Is not the same to see the info on the quicklook preview but it can be useful.

@Lessica
Copy link

Lessica commented Apr 10, 2022

Tested on macOS Monterey:
qlImageSize won't work for any format it supported now.

.bpg -> dyn.ah62d4rv4ge80e6dh
.webp is now declared by system.

kMDItemContentType                     = "org.webmproject.webp"
kMDItemContentTypeTree                 = (
    "org.webmproject.webp",
    "public.image",
    "public.data",
    "public.item",
    "public.content"
)

The new QuickLook extensions (.appex) won't work for system declared UTIs.

@Nyx0uf Nyx0uf added the status: Abandoned Will not be fixed label Mar 3, 2023
@Nyx0uf Nyx0uf changed the title Catalina Support? macOS 10.15+ Support Mar 3, 2023
@toFrankie
Copy link

This plugin is great. Hope there will be a turnaround in the future.

@Joan
Copy link

Joan commented Mar 7, 2024

https://github.com/sbarex/MediaInfo is a great replacement: it shows more info in the contextual menu for more file types, and is higly customisable

@setanarut
Copy link

https://github.com/sbarex/MediaInfo is a great replacement: it shows more info in the contextual menu for more file types, and is higly customisable

it is not a replacement. macOS already has a similar feature that's easier. Choose File > Get Info, or press Command-I.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: Abandoned Will not be fixed
Projects
None yet
Development

No branches or pull requests