Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about bad glosses #50

Open
fnielsen opened this issue Oct 8, 2020 · 4 comments
Open

Warn about bad glosses #50

fnielsen opened this issue Oct 8, 2020 · 4 comments

Comments

@fnielsen
Copy link

fnielsen commented Oct 8, 2020

Sometimes the gloss from Q-item descriptions are too generic, see, e.g., https://www.wikidata.org/w/index.php?title=Lexeme:L49191&diff=1155328002&oldid=965893559 (mammal family). MachtSinn could warn if the gloss is not unique.

@dpriskorn
Copy link
Collaborator

I can create a pull request that filters out descriptions that contain less than 2 spaces (3 words). Would that be accepted @Nudin ?

@Nudin
Copy link
Owner

Nudin commented Jan 24, 2021

Sounds like a good idea, but I would prefer not to completely filter out all such matches, since it would result in many languages having no matches at all. I see two possibilities:

  • Filter those matches out only for big languages (in the backend, backend.py)
  • In the frontend (JavaScript): automatically go into edit-mode and either ask the user to improve the gloss or force him (disable the submit button)

Maybe a combination of both would be best? @egils-consulting if you implement one of those or a combination I happily accept it.

@dpriskorn
Copy link
Collaborator

I would like the description on the Qid to be improved also before implementing this as that's a higher priority if you ask me.

@dpriskorn
Copy link
Collaborator

dpriskorn commented Aug 18, 2021

In #76 I filtered out everything with less than 1 space and that seemed to work fine. It took away a lot of heraldic garbage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants