Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade of mongoose to +5.5.x #48

Open
YasharF opened this issue Apr 8, 2019 · 5 comments
Open

Upgrade of mongoose to +5.5.x #48

YasharF opened this issue Apr 8, 2019 · 5 comments
Labels
PRs Welcome PRs Welcome

Comments

@YasharF
Copy link
Contributor

YasharF commented Apr 8, 2019

Upgrade of mongoose was omitted from #46 even though npm audit calls it out to have an issue. I did make an attempt to do the upgrade in package.json, but it looks like that there is a breaking change and it causes npm test to fail.
@gaguirre
Copy link
Collaborator

Thanks for reporting this. Let me know if you've some more info about it.

@YasharF
Copy link
Contributor Author

YasharF commented Apr 22, 2019 •
edited

By some trial and error when running npm test, I have narrowed that 5.3.16 -> 5.4.0 is the breaking change. The three tests that failed are the "verify chained" tests.

Here is the changelog for mongoose at that point: https://github.com/Automattic/mongoose/blob/master/History.md#540--2018-12-14

@YasharF
Copy link
Contributor Author

YasharF commented Apr 22, 2019

With #49 mongoose is getting bumped to 5.3.16 by the way.

@YasharF YasharF added the PRs Welcome PRs Welcome label Jun 9, 2019
@dhuang612
Copy link

I'll work on this

@dhuang612
Copy link

dhuang612 commented Oct 21, 2019 •
edited

Hi,

I created PR #53
with all tests working now.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PRs Welcome PRs Welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaguirre @YasharF @dhuang612