-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rSpeedGraph is not defined #2478
Comments
Please clear your web browser cache. The development branch doesn't clear it for you. It looks like |
I already cleared the cache, even started new instances of the browsers with clean profiles, I still get the same errors. |
Do you have any custom plugins installed that are not distributed with ruTorrent? We changed the speed graph to the point where it may cause breakage in version 4.1. The old speed graph couldn't scale with thousands of torrents. |
There is a plugin called The extra plugins installed are in the |
I looked at your docker file. Almost all of these plugins on Line 131 are not compatible with version 4. The repo of plugins you've installed are nine years old and not updated for version 4. |
I rebuilt with non-master rtorrent |
Did you disable this plugin as well? Whether or not these errors went undetected are unknown. But lines this like will throw an error when they run on v4.0.4. It should be like this instead. This is one of many examples of compatibility issues. |
Yes all the |
@TrimmingFool Are these lines of code compatible with version 4.1? The way they are implemented? https://github.com/Novik/ruTorrent/blob/develop/plugins/theme/themes/Excel/init.js#L39-L45
https://github.com/Novik/ruTorrent/blob/develop/js/webui.js#L236 |
@stickz can you test on Waterfox Classic, or Firefox? Whatever I do, the |
Try deleting |
This would explain why it works on Chrome but not Firefox. Firefox may be treating |
After many testing on Chrome (since Firefox is borked), I found that newly added torrents are fine, but restoring session files from v4.0 session folder ( |
Could you git clone develop to verify this problem is resolved? Afterwards, I'll create a new release. |
@stickz we have a lift off on Chrome. Also, it takes 2 seconds to load the webui, it's pretty fast. Previously it would take 5-6 seconds, as described in this issue #2427. It's not even necessary to set This current setup is with the P.S. Also tested Firefox and Microsoft Edge in a Windows 10 sandbox, they both work. It's Waterfox Classic that is still stuck with the rSpeedGraph error. |
If the disk becomes loaded, it will take much longer. Since you have a docker container an alternative solution would be to use vmtouch. It's more stable, but harder to setup.
Sound good. One additional tip. I would recommend using curl instead of libwww for xmlrpc. There are significant performance issues with thousands of torrents. It hammers the hard drive and slows down torrent distribution. curl is faster and more stable.
There are no plans to support a beta version of a web browser. I'm going to close this issue since the problem is resolved. Please free to create anther issue, if you find additional problems. We greatly value your feedback and ability to test things thoroughly! |
Indeed I'm using curl. Waterfox Classic is not a beta by the way, it's a browser that supports legacy Firefox addons. I would use Firefox but sadly many of the legacy addons don't work on it anymore and don't have any alternatives. I really hope you guys can fix this rSpeedGraph issue. Thanks for the effort. |
One last request, is it possible to make the speed graph optional in the config.php? I don't even use it to begin with. By disabling it, I can have a workaround to the Waterfox Classic problem, if you don't have time to dig more into it. Thanks. |
@TrimmingFool Is there any way we could make the speed graph modular in version 4.2, so it's not directly connected to the web interface? There are other plugin implements such as I strongly agree with @buggsi that we should provide users with the option to disable this feature. The redundancy aspects would highly benefit the robustness of the web interface and it would give developers more control to further customize this feature. |
@stickz |
@Novik When the plugin is disabled, the entire speed graph object plus tab will be deleted. Similar to how the |
@stickz In my opinion, plugins are a great way to split up code ownership, not so much for modularity. An option/setting is easier to maintain than a plugin which is basically a patch/mod. It is true however, that |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please complete the following tasks.
Tell us about your environment
Web Browser: Waterfox Classic and Chrome
ruTorrent: v4.1-beta.4
PHP: PHP 7.4.3
OS: Alpine 3.14
Tell us how you installed ruTorrent
rtorrent
master
libtorrent
master
rutorrent
v4.1-beta.4
https://github.com/romancin/rutorrent-docker/tree/develop
Describe the bug
On Waterfox Classic, the webui is stuck on the loading screen:
On Chrome, the webui loads, the torrents are listed on the right panel, but the states are zeroed,
Also, with this repeating error in the log:
2023-04-10 14:54:36] JS error: [http://***:***@******:91/js/webui.js?v=410 : 2184] Uncaught TypeError: Cannot read properties of undefined (reading 'includes')
Steps to reproduce
No response
Expected behavior
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: