Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port inheritance with deeply nested modules #21

Open
DivadNojnarg opened this issue Feb 13, 2020 · 1 comment
Open

Port inheritance with deeply nested modules #21

DivadNojnarg opened this issue Feb 13, 2020 · 1 comment
Assignees

Comments

@DivadNojnarg
Copy link
Collaborator

DivadNojnarg commented Feb 13, 2020

What I noticed:

  • If a parent module has 1 child, all its input ports are copied (by default) to the child input ports (unless we specify inherit = FALSE during the nested module initialisation). This is what we expect
  • Now we create a nested module in the child module. In the meantime, we decide to add a new input port to the child module. Then the nested module (grand child) will only inherit from the direct parent and not from the grand parent + the parent

There are a lot of use case where it would be convenient to inherit from multiple layers.

This feature should be included with the ability to choose whether to inherit from the direct parent, the whole chain or maybe a given number of parents (if n is 2, we inherit from the parent and the grand parent)...

Do you have comments @xni7 and @m-l-1 ?

I also might have missed something

@xni7
Copy link
Collaborator

xni7 commented Feb 14, 2020

I like @DivadNojnarg 's proposal. I think the default may be recursive inheritance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants