Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to build a graph from a CST and extract CLI commands into the runtime library #983

Merged
merged 19 commits into from
Jun 10, 2024

Conversation

ggiraldez
Copy link
Contributor

@ggiraldez ggiraldez commented May 25, 2024

Closes #981

  1. Exposes the metaslang_graph_builder functionality in the generated languages runtime, parameterized with the language KindTypes.
  2. Exercise the graph builder via a test in testlang.
  3. Extracts the CLI command from slang_solidity into the runtime crate to be able to easily reuse it from other generated languages.
  4. Adds a new build-graph command to the common CLI commands to run a source file through an arbitrary .msgb file and build a graph.
  5. Expose the language's root non-terminal kind in the public API.

Items 1, 2 and 4 are only available when building with the private feature flag __graph_builder.

Copy link

changeset-bot bot commented May 25, 2024

🦋 Changeset detected

Latest commit: 23d91a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@nomicfoundation/slang Patch
@nomicfoundation/slang-darwin-arm64 Patch
@nomicfoundation/slang-darwin-x64 Patch
@nomicfoundation/slang-linux-arm64-gnu Patch
@nomicfoundation/slang-linux-arm64-musl Patch
@nomicfoundation/slang-linux-x64-gnu Patch
@nomicfoundation/slang-linux-x64-musl Patch
@nomicfoundation/slang-win32-arm64-msvc Patch
@nomicfoundation/slang-win32-ia32-msvc Patch
@nomicfoundation/slang-win32-x64-msvc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ggiraldez ggiraldez changed the title Export graph builder in the generated languages runtime and add build-graph command to slang_solidity Add command to build a graph from a CST and extract CLI commands into the runtime library May 29, 2024
@ggiraldez ggiraldez marked this pull request as ready for review May 29, 2024 16:51
@ggiraldez ggiraldez requested a review from a team as a code owner May 29, 2024 16:51
Copy link
Collaborator

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions.
Happy to discuss f2f first to get a better understanding.

@ggiraldez ggiraldez requested a review from OmarTawfik June 7, 2024 00:41
Copy link
Collaborator

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new changes!

I think the only thing remaining here is adding the new crate to USER_FACING_CRATES.

@OmarTawfik OmarTawfik added this pull request to the merge queue Jun 10, 2024
Merged via the queue into NomicFoundation:main with commit ea31417 Jun 10, 2024
1 check passed
@ggiraldez ggiraldez deleted the feat/981-graph-builder-cli branch June 10, 2024 17:38
@github-actions github-actions bot mentioned this pull request Jun 10, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 11, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @nomicfoundation/[email protected]

### Minor Changes

- [#975](#975)
[`46b1dde`](46b1dde)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`QueryResult` to `QueryMatch`, and its `bindings` to `captures`.

- [#971](#971)
[`be943b7`](be943b7)
Thanks [@Xanewok](https://github.com/Xanewok)! - Rename `RuleKind` to
`NonterminalKind`, `TokenKind` to `TerminalKind`, and `NodeLabel` to
`EdgeLabel`.

- [#963](#963)
[`a5593f9`](a5593f9)
Thanks [@Xanewok](https://github.com/Xanewok)! - Introduce a
`Diagnostic` API for compiler errors, warnings etc.

### Patch Changes

- [#996](#996)
[`cdc153d`](cdc153d)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for
version `0.8.26`.

- [#983](#983)
[`ea31417`](ea31417)
Thanks [@ggiraldez](https://github.com/ggiraldez)! - Expose the language
root non-terminal kind at `Language.rootKind()`.

- [#965](#965)
[`61b6b06`](61b6b06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - refactor CST
building and querying utilities into a separate `metaslang_cst` crate.

- [#997](#997)
[`84ad856`](84ad856)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Support stack
assignments in Yul before `0.5.0`.

## @nomicfoundation/[email protected]

### Minor Changes

- [#975](#975)
[`46b1dde`](46b1dde)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`QueryResult` to `QueryMatch`, and its `bindings` to `captures`.

- [#971](#971)
[`be943b7`](be943b7)
Thanks [@Xanewok](https://github.com/Xanewok)! - Rename `RuleKind` to
`NonterminalKind`, `TokenKind` to `TerminalKind`, and `NodeLabel` to
`EdgeLabel`.

- [#963](#963)
[`a5593f9`](a5593f9)
Thanks [@Xanewok](https://github.com/Xanewok)! - Introduce a
`Diagnostic` API for compiler errors, warnings etc.

### Patch Changes

- [#996](#996)
[`cdc153d`](cdc153d)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for
version `0.8.26`.

- [#983](#983)
[`ea31417`](ea31417)
Thanks [@ggiraldez](https://github.com/ggiraldez)! - Expose the language
root non-terminal kind at `Language.rootKind()`.

- [#965](#965)
[`61b6b06`](61b6b06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - refactor CST
building and querying utilities into a separate `metaslang_cst` crate.

- [#997](#997)
[`84ad856`](84ad856)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Support stack
assignments in Yul before `0.5.0`.

## @nomicfoundation/[email protected]

### Minor Changes

- [#975](#975)
[`46b1dde`](46b1dde)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`QueryResult` to `QueryMatch`, and its `bindings` to `captures`.

- [#971](#971)
[`be943b7`](be943b7)
Thanks [@Xanewok](https://github.com/Xanewok)! - Rename `RuleKind` to
`NonterminalKind`, `TokenKind` to `TerminalKind`, and `NodeLabel` to
`EdgeLabel`.

- [#963](#963)
[`a5593f9`](a5593f9)
Thanks [@Xanewok](https://github.com/Xanewok)! - Introduce a
`Diagnostic` API for compiler errors, warnings etc.

### Patch Changes

- [#996](#996)
[`cdc153d`](cdc153d)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for
version `0.8.26`.

- [#983](#983)
[`ea31417`](ea31417)
Thanks [@ggiraldez](https://github.com/ggiraldez)! - Expose the language
root non-terminal kind at `Language.rootKind()`.

- [#965](#965)
[`61b6b06`](61b6b06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - refactor CST
building and querying utilities into a separate `metaslang_cst` crate.

- [#997](#997)
[`84ad856`](84ad856)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Support stack
assignments in Yul before `0.5.0`.

## @nomicfoundation/[email protected]

### Minor Changes

- [#975](#975)
[`46b1dde`](46b1dde)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`QueryResult` to `QueryMatch`, and its `bindings` to `captures`.

- [#971](#971)
[`be943b7`](be943b7)
Thanks [@Xanewok](https://github.com/Xanewok)! - Rename `RuleKind` to
`NonterminalKind`, `TokenKind` to `TerminalKind`, and `NodeLabel` to
`EdgeLabel`.

- [#963](#963)
[`a5593f9`](a5593f9)
Thanks [@Xanewok](https://github.com/Xanewok)! - Introduce a
`Diagnostic` API for compiler errors, warnings etc.

### Patch Changes

- [#996](#996)
[`cdc153d`](cdc153d)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for
version `0.8.26`.

- [#983](#983)
[`ea31417`](ea31417)
Thanks [@ggiraldez](https://github.com/ggiraldez)! - Expose the language
root non-terminal kind at `Language.rootKind()`.

- [#965](#965)
[`61b6b06`](61b6b06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - refactor CST
building and querying utilities into a separate `metaslang_cst` crate.

- [#997](#997)
[`84ad856`](84ad856)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Support stack
assignments in Yul before `0.5.0`.

## @nomicfoundation/[email protected]

### Minor Changes

- [#975](#975)
[`46b1dde`](46b1dde)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`QueryResult` to `QueryMatch`, and its `bindings` to `captures`.

- [#971](#971)
[`be943b7`](be943b7)
Thanks [@Xanewok](https://github.com/Xanewok)! - Rename `RuleKind` to
`NonterminalKind`, `TokenKind` to `TerminalKind`, and `NodeLabel` to
`EdgeLabel`.

- [#963](#963)
[`a5593f9`](a5593f9)
Thanks [@Xanewok](https://github.com/Xanewok)! - Introduce a
`Diagnostic` API for compiler errors, warnings etc.

### Patch Changes

- [#996](#996)
[`cdc153d`](cdc153d)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for
version `0.8.26`.

- [#983](#983)
[`ea31417`](ea31417)
Thanks [@ggiraldez](https://github.com/ggiraldez)! - Expose the language
root non-terminal kind at `Language.rootKind()`.

- [#965](#965)
[`61b6b06`](61b6b06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - refactor CST
building and querying utilities into a separate `metaslang_cst` crate.

- [#997](#997)
[`84ad856`](84ad856)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Support stack
assignments in Yul before `0.5.0`.

## @nomicfoundation/[email protected]

### Minor Changes

- [#975](#975)
[`46b1dde`](46b1dde)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`QueryResult` to `QueryMatch`, and its `bindings` to `captures`.

- [#971](#971)
[`be943b7`](be943b7)
Thanks [@Xanewok](https://github.com/Xanewok)! - Rename `RuleKind` to
`NonterminalKind`, `TokenKind` to `TerminalKind`, and `NodeLabel` to
`EdgeLabel`.

- [#963](#963)
[`a5593f9`](a5593f9)
Thanks [@Xanewok](https://github.com/Xanewok)! - Introduce a
`Diagnostic` API for compiler errors, warnings etc.

### Patch Changes

- [#996](#996)
[`cdc153d`](cdc153d)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for
version `0.8.26`.

- [#983](#983)
[`ea31417`](ea31417)
Thanks [@ggiraldez](https://github.com/ggiraldez)! - Expose the language
root non-terminal kind at `Language.rootKind()`.

- [#965](#965)
[`61b6b06`](61b6b06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - refactor CST
building and querying utilities into a separate `metaslang_cst` crate.

- [#997](#997)
[`84ad856`](84ad856)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Support stack
assignments in Yul before `0.5.0`.

## @nomicfoundation/[email protected]

### Minor Changes

- [#975](#975)
[`46b1dde`](46b1dde)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`QueryResult` to `QueryMatch`, and its `bindings` to `captures`.

- [#971](#971)
[`be943b7`](be943b7)
Thanks [@Xanewok](https://github.com/Xanewok)! - Rename `RuleKind` to
`NonterminalKind`, `TokenKind` to `TerminalKind`, and `NodeLabel` to
`EdgeLabel`.

- [#963](#963)
[`a5593f9`](a5593f9)
Thanks [@Xanewok](https://github.com/Xanewok)! - Introduce a
`Diagnostic` API for compiler errors, warnings etc.

### Patch Changes

- [#996](#996)
[`cdc153d`](cdc153d)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for
version `0.8.26`.

- [#983](#983)
[`ea31417`](ea31417)
Thanks [@ggiraldez](https://github.com/ggiraldez)! - Expose the language
root non-terminal kind at `Language.rootKind()`.

- [#965](#965)
[`61b6b06`](61b6b06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - refactor CST
building and querying utilities into a separate `metaslang_cst` crate.

- [#997](#997)
[`84ad856`](84ad856)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Support stack
assignments in Yul before `0.5.0`.

## @nomicfoundation/[email protected]

### Minor Changes

- [#975](#975)
[`46b1dde`](46b1dde)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`QueryResult` to `QueryMatch`, and its `bindings` to `captures`.

- [#971](#971)
[`be943b7`](be943b7)
Thanks [@Xanewok](https://github.com/Xanewok)! - Rename `RuleKind` to
`NonterminalKind`, `TokenKind` to `TerminalKind`, and `NodeLabel` to
`EdgeLabel`.

- [#963](#963)
[`a5593f9`](a5593f9)
Thanks [@Xanewok](https://github.com/Xanewok)! - Introduce a
`Diagnostic` API for compiler errors, warnings etc.

### Patch Changes

- [#996](#996)
[`cdc153d`](cdc153d)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for
version `0.8.26`.

- [#983](#983)
[`ea31417`](ea31417)
Thanks [@ggiraldez](https://github.com/ggiraldez)! - Expose the language
root non-terminal kind at `Language.rootKind()`.

- [#965](#965)
[`61b6b06`](61b6b06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - refactor CST
building and querying utilities into a separate `metaslang_cst` crate.

- [#997](#997)
[`84ad856`](84ad856)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Support stack
assignments in Yul before `0.5.0`.

## @nomicfoundation/[email protected]

### Minor Changes

- [#975](#975)
[`46b1dde`](46b1dde)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`QueryResult` to `QueryMatch`, and its `bindings` to `captures`.

- [#971](#971)
[`be943b7`](be943b7)
Thanks [@Xanewok](https://github.com/Xanewok)! - Rename `RuleKind` to
`NonterminalKind`, `TokenKind` to `TerminalKind`, and `NodeLabel` to
`EdgeLabel`.

- [#963](#963)
[`a5593f9`](a5593f9)
Thanks [@Xanewok](https://github.com/Xanewok)! - Introduce a
`Diagnostic` API for compiler errors, warnings etc.

### Patch Changes

- [#996](#996)
[`cdc153d`](cdc153d)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for
version `0.8.26`.

- [#983](#983)
[`ea31417`](ea31417)
Thanks [@ggiraldez](https://github.com/ggiraldez)! - Expose the language
root non-terminal kind at `Language.rootKind()`.

- [#965](#965)
[`61b6b06`](61b6b06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - refactor CST
building and querying utilities into a separate `metaslang_cst` crate.

- [#997](#997)
[`84ad856`](84ad856)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Support stack
assignments in Yul before `0.5.0`.

## @nomicfoundation/[email protected]

### Minor Changes

- [#975](#975)
[`46b1dde`](46b1dde)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`QueryResult` to `QueryMatch`, and its `bindings` to `captures`.

- [#971](#971)
[`be943b7`](be943b7)
Thanks [@Xanewok](https://github.com/Xanewok)! - Rename `RuleKind` to
`NonterminalKind`, `TokenKind` to `TerminalKind`, and `NodeLabel` to
`EdgeLabel`.

- [#963](#963)
[`a5593f9`](a5593f9)
Thanks [@Xanewok](https://github.com/Xanewok)! - Introduce a
`Diagnostic` API for compiler errors, warnings etc.

### Patch Changes

- [#996](#996)
[`cdc153d`](cdc153d)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for
version `0.8.26`.

- [#983](#983)
[`ea31417`](ea31417)
Thanks [@ggiraldez](https://github.com/ggiraldez)! - Expose the language
root non-terminal kind at `Language.rootKind()`.

- [#965](#965)
[`61b6b06`](61b6b06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - refactor CST
building and querying utilities into a separate `metaslang_cst` crate.

- [#997](#997)
[`84ad856`](84ad856)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Support stack
assignments in Yul before `0.5.0`.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a parametric .msgb graph builder diagnostic CLI tool
2 participants