Add CST labels to EBNF #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OmarTawfik
reviewed
May 25, 2024
OmarTawfik
reviewed
May 26, 2024
OmarTawfik
reviewed
May 27, 2024
ggiraldez
force-pushed
the
feat/916-add-cst-labels-to-ebnf
branch
2 times, most recently
from
52fcc10
to
8ab4b58
Compare
OmarTawfik
reviewed
May 28, 2024
OmarTawfik
requested changes
May 28, 2024
ggiraldez
force-pushed
the
feat/916-add-cst-labels-to-ebnf
branch
from
a2fb1b7
to
e6a72c0
Compare
Missing some built-in labels, such as those internal to operators and items and separators.
Because they are not direct children of Topic, they were being omitted from the output when building the language spec.
This allows labelling Separated, which was the remaining grammar Item that needed it.
Co-authored-by: Omar Tawfik <[email protected]>
ggiraldez
force-pushed
the
feat/916-add-cst-labels-to-ebnf
branch
from
e6a72c0
to
4ca53ee
Compare
OmarTawfik
approved these changes
May 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
Spin off of #976 Moves the `BuiltInLabel` enum from the parser generator into the language definition and remove duplication in the `kinds` template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #916
Closes #917
The changes add the corresponding CST labels to the generated EBNF grammar representation, via the use of a leading comment before the appropriate references (which represent the nodes in the CST).
This PR also adds the
PrecedenceExpressionvisible in the generated EBNF, fixing #917. Since they are not direct children of theTopics they were being omitted from the language specification.A couple of questions/items I have doubts on:
I copied the
BuiltInLabelsenum from the grammar generator crate because it was private and not directly accessible from theebnfcrate. But I think it may make sense to move the enum into thelanguage_definitioncrate? It may make it possible to remove all the duplication.A minor concern is the readability of the resulting EBNF, for sequences in particular. Adding the labels introduces noise to the spec document already. But for separated sequences, the resulting lines almost never fit into the enclosing box in the HTML, which forces horizontal scrolling.