Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validation for AST operator types #872

Closed
OmarTawfik opened this issue Mar 2, 2024 · 0 comments · Fixed by #1000
Closed

add validation for AST operator types #872

OmarTawfik opened this issue Mar 2, 2024 · 0 comments · Fixed by #1000
Assignees
@OmarTawfik

Comments

@OmarTawfik
Copy link
Collaborator

OmarTawfik commented Mar 2, 2024 •
edited

Please check the TODO(#872) comments added in #873.
@OmarTawfik OmarTawfik self-assigned this Mar 2, 2024
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Jun 10, 2024
@OmarTawfik
use labels for AST selectors
0d0435f 
Uses labels to select AST nodes, which is more accurate, requires less code (instead of checking individual kinds), and also fixes a bug where additional `TerminalKind`s of `PrecedenceOperator` are not taken into account.

Closes NomicFoundation#872
Closes NomicFoundation#986
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Jun 10, 2024
@OmarTawfik
use labels for AST selectors
3fcde27 
Uses labels to select AST nodes, which is more accurate, requires less code (instead of checking individual kinds), and also fixes a bug where additional `TerminalKind`s of `PrecedenceOperator` are not taken into account.

Closes NomicFoundation#872
Closes NomicFoundation#986
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Jun 10, 2024
@OmarTawfik
use labels for AST selectors
78fa040 
Uses labels to select AST nodes, which is more accurate, requires less code (instead of checking individual kinds), and also fixes a bug where additional `TerminalKind`s of `PrecedenceOperator` are not taken into account.

Closes NomicFoundation#872
Closes NomicFoundation#986
@OmarTawfik OmarTawfik mentioned this issue Jun 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 11, 2024
@OmarTawfik
use labels for AST selectors (#1000)
b78b0ea 
Uses labels to select AST nodes, which is more accurate, requires less
code (instead of checking individual kinds), and also fixes a bug where
additional `TerminalKind`s of `PrecedenceOperator` are not taken into
account.

Closes #872
Closes #986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OmarTawfik OmarTawfik

Labels
None yet
Projects
Slang - 2024 H1
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use labels for AST selectors OmarTawfik-forks/slang
1 participant
@OmarTawfik