-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using references in the public API #820
Comments
OmarTawfik
changed the title
returning references from public API
using references in the public API
Feb 15, 2024
Not sure about that. We should maybe return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Incoming
Can we accept a reference to the source string in
Language::parse()
instead of owning it? using shared memory?Is it worth it to avoid the copies in case of large strings?
Outgoing
Many API calls currently involve cloning and returning an
Rc<T>
needlessly, rather than returning&T
. We should review and convert them where needed.The text was updated successfully, but these errors were encountered: