Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "please report to the Hardhat team" from hardhat-verify #5166

Closed
kanej opened this issue Apr 24, 2024 · 2 comments · Fixed by #5203
Closed

Remove "please report to the Hardhat team" from hardhat-verify #5166

kanej opened this issue Apr 24, 2024 · 2 comments · Fixed by #5203
Assignees
Labels
area:hardhat-verify status:ready This issue is ready to be worked on type:chore A task related to code quality, tooling, CI, or anything that doesn't directly impact the end users

Comments

@kanej
Copy link
Member

kanej commented Apr 24, 2024

We see lots of issues with hardhat-verify that are really temporary issues with the block explorer or an odd setup, or just a block explorer that doesn't meet the expected api. However due to our error message, it is reported as an issue:

Etherscan:
An unexpected error occurred during the verification process.
Please report this issue to the Hardhat team.
Error Details: Unexpected token '<', "

<!DOCTYPE "... is not valid JSON

To give an example:
#5111

We should alter this error message to:

  1. Remove the request to report the issue
  2. If we can pass through any more details from the underlying error/block explorer, that we do that

In particular, if we could display more of the failed http response (particularly if it is an HTML file) we are likely to get less support requests - maybe include the entirety of the failed http response in debug for instance.

Our goal here is to try and minimize the support burden of issues in the block explorers taking up Hardhat investigation time.

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Apr 24, 2024
@kanej kanej added area:hardhat-verify type:chore A task related to code quality, tooling, CI, or anything that doesn't directly impact the end users labels Apr 24, 2024
@0xV4L3NT1N3
Copy link

Chiming in from Etherscan, open to ideas how to directly forward suspected verification API issues to us!

@kanej
Copy link
Member Author

kanej commented May 7, 2024

Talking it through some more. Etherscan is providing only that the verification failed, no further details. Other block explorers might throw an http error and return an html error page.

So lets look at

  • Change the error to indicate:
    • verification worked locally, this is not a HH issue
    • your next steps are to work with the block explorer directly, as they are giving no more details
    • if it is an http error rather than a 200 but failed verification we should investigate what printing the entire output would look like. Maybe look at hiding this behind debug with a note to include debug to see more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:hardhat-verify status:ready This issue is ready to be worked on type:chore A task related to code quality, tooling, CI, or anything that doesn't directly impact the end users
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants