Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ethereumjs usages with micro-eth-signer #5155

Open
2 tasks
kanej opened this issue Apr 22, 2024 · 1 comment
Open
2 tasks

Replace ethereumjs usages with micro-eth-signer #5155

kanej opened this issue Apr 22, 2024 · 1 comment
Labels
status:ready This issue is ready to be worked on type:chore A task related to code quality, tooling, CI, or anything that doesn't directly impact the end users
Milestone
vnext

Comments

@kanej
Copy link
Member

kanej commented Apr 22, 2024 •
edited

Replace ethereumjs usages with micro-eth-signer for Hardhat v3.

With EDR replacing the Hardhat Network with a rust implementation we are using Ethereumjs less. We suspect our remaining usages are related to signing. This task is to replace those usages.

We intend to use micro-eth-signer as it is small and focused with 3 deps.

TODO

  • A quick analysis of ethereumjs usages across the HHv3 codebase, identifying those usages that can be replaced with the micro-eth-signer and which can't (creating a follow up issue for those cases)
  • Swap in the micro-eth-signer for these cases
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Apr 22, 2024
@kanej kanej added this to the vnext milestone Apr 22, 2024
@kanej kanej added the type:chore A task related to code quality, tooling, CI, or anything that doesn't directly impact the end users label Apr 22, 2024
@kanej
Copy link
Member Author

kanej commented May 7, 2024

Questions

  1. Is the intent to replace actual usages in v3 with the signer, or provide a utils option that can be used in the future
  2. Are there existing utils that could leverage signer instead of ethereum/js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on type:chore A task related to code quality, tooling, CI, or anything that doesn't directly impact the end users
Projects
Hardhat
Status: To-do
Milestone
vnext
Development

No branches or pull requests
1 participant
@kanej