@nomiclabs/hardhat-solhint does not work

[sherpya]

Version of Hardhat

2.12.7

What happened?

NomicLabsHardhatPluginError: An error occurred loading the solhint formatter stylish
    at getFormatter (.../node_modules/@nomiclabs/hardhat-solhint/src/index.ts:21:11

Caused by: Error: Cannot find module 'eslint/lib/formatters/stylish'

calling:

https://github.com/NomicFoundation/hardhat/blob/main/packages/hardhat-solhint/src/index.ts#L12

Minimal reproduction steps

• create hardhat project using typescript and default settings
• add hardhat-solhint and enable in config
• run npx hardhat check

Search terms

solhint hardhat-solhint

[yhuard]

I have the same issue. I'll try to push a fix later today

[Oni-giri]

@yhuard Please consider addressing this issue along: #1665

[yhuard]

@Oni-giri I'll have a look on my free time 👌

[mhm13dev]

@yhuard Just to update you:
You fixed this issue in #3726 but when I installed hardhat-solhint I still get this error.
When I checked in node_modules, your fix is not included

[yhuard]

Hi @mhm13dev!
Indeed, the changes have not been published yet. The last update of the @nomiclabs/hardhat-solhint package was on December 29, 2022, while my PR was merged on March 4, 2023.
Until a new version of the package is published, I use patch-package in my projects in order to patch it.
Here's what the patch looks like:

diff --git a/node_modules/@nomiclabs/hardhat-solhint/dist/src/index.js b/node_modules/@nomiclabs/hardhat-solhint/dist/src/index.js
index acf1244..cbaff27 100644
--- a/node_modules/@nomiclabs/hardhat-solhint/dist/src/index.js
+++ b/node_modules/@nomiclabs/hardhat-solhint/dist/src/index.js
@@ -30,8 +30,7 @@ function getDefaultConfig() {
 }
 function getFormatter(formatterName = "stylish") {
     try {
-        const solhintPath = require.resolve("solhint");
-        const formatterPath = require.resolve(`eslint/lib/formatters/${formatterName}`, { paths: [solhintPath] });
+        const formatterPath = require.resolve(`solhint/lib/formatters/${formatterName}`);
         return require(formatterPath);
     }
     catch (ex) {

[mhm13dev]

Okay I will use the patch-package for now.
Appreciated 👍