Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacer repo npm-compatible #107

Open
Xabadu opened this issue Mar 4, 2018 · 4 comments
Open

Hacer repo npm-compatible #107

Xabadu opened this issue Mar 4, 2018 · 4 comments
Assignees
Labels

Comments

@Xabadu
Copy link
Contributor

Xabadu commented Mar 4, 2018

Actualmente el sitio no anda si la instalación se hace por npm en vez de yarn. Let's fix this 🍪

@Xabadu
Copy link
Contributor Author

Xabadu commented Mar 5, 2018

Este issue no está solucionado aún 💔

Ojo que la instalación con npm siempre funcionó (iba a publicar eso en el review original), pero al hacerla, lanza un error al correr npm start.


✖ ERROR ./src/components/app.js
Module parse failed: Identifier 'h' has already been declared (9:9)
You may need an appropriate loader to handle this file type.
| function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function, not " + typeof superClass); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, enumerable: false, writable: true, configurable: true } }); if (superClass) Object.setPrototypeOf ? Object.setPrototypeOf(subClass, superClass) : subClass.__proto__ = superClass; }
|
| import { h, Component } from 'preact';
| import { Router } from 'preact-router';
| import Header from './header';
 @ ./src/index.js 4:0-35
 @ ./node_modules/preact-cli/lib/lib/entry.js
 @ multi ./node_modules/preact-cli/lib/lib/entry webpack-dev-server/client webpack/hot/dev-server```

@Xabadu Xabadu reopened this Mar 5, 2018
@enBonnet
Copy link
Contributor

¿Como se puede solucionar esto?

@tatymoly
Copy link
Contributor

Es tema de versión de dependencias creo

@luchosrock
Copy link

Y qué hay con este warning de yarn cuando encuentra un package-lock?

https://github.com/yarnpkg/yarn/blob/c040e7918dca811e0d4b54a949fd6f3be403a777/src/reporters/lang/en.js#L98

'package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.'

Aquí un post al respecto https://yarnpkg.com/blog/2018/06/04/yarn-import-package-lock/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants