Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] core's _build_fn_name has unexpected interactions with reconciler's attributes #148

Open
kdgutier opened this issue Dec 30, 2022 · 1 comment

Comments

@kdgutier
Copy link
Collaborator

When using for a second time an object instantiated from the HierarchicalReconciliation, the attributes that its self.reconcilers store as part of their fit affect the final column names

I traced back the error to core's _build_fn_name that uses all the original and new attributes from the self.reconcilers.

This is problematic for new methods that recycle self.reconcilers.
For example the recently added bootstrap_reconcile

@kdgutier kdgutier added the bug label Dec 30, 2022
@kdgutier
Copy link
Collaborator Author

I added a momentary hack, by deep copying the original reconcilers that I use for _build_fn_name
and use the new reconcilers like normally used.

@cchallu cchallu removed the bug label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants