Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag name is dangerous #45

Open
roberth opened this issue Aug 14, 2022 · 2 comments · May be fixed by #13
Open

Tag name is dangerous #45

roberth opened this issue Aug 14, 2022 · 2 comments · May be fixed by #13

Comments

@roberth
Copy link
Member

roberth commented Aug 14, 2022 •
edited 

{
  inputs.nixpkgs.url = "NixOS/nixpkgs/22.05";
}

Did you spot the security issue?

Let's replace the release tags by something descriptive, like 22.05-start or 22.05.0, so that users don't accidentally fail to update their packages.
@roberth roberth linked a pull request Aug 14, 2022 that will close this issue
Open
@dasJ
Copy link
Member

dasJ commented Aug 14, 2022

While I agree with the point in general, this particular example feels like a niv bug.
I wouldn't expect --branch to use a tag.

@roberth
Copy link
Member Author

roberth commented Aug 14, 2022

this particular example feels like a niv bug.

That's fair actually. I figured I'd add a non-flake example, but this is not it. Editing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add -start to release tag roberth/release-wiki
2 participants
@roberth @dasJ