dotnet 3.1 is EOL #202572

mdarocha · 2022-11-23T18:43:44Z

Issue description

Since December 13, .NET 3.1 is unsupported, as per https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

We should work on updating packages that make use of it, and deprecating this dotnet version

Steps to reproduce

See https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

Replacing packages using `dotnet-sdk_3`

./pkgs/applications/blockchains/wasabibackend/default.nix - wasabibackend: 1.1.13.1 -> 2.0.2.1 #209429
./pkgs/tools/games/opentracker/default.nix - alttpr-opentracker: 1.8.2 -> 1.8.5 #209427
./pkgs/servers/web-apps/baget/default.nix - baget: remove due to upstream being unmaintained #222006
./pkgs/development/tools/azure-functions-core-tools/default.nix - azure-functions-core-tools: 4.0.4785 -> 4.0.4915 #209593
./pkgs/development/compilers/inklecate/default.nix - inklecate: 1.0.0 -> 1.1.1 #208554
./pkgs/development/dotnet-modules/python-language-server/default.nix - python-language-server: remove #209586
./pkgs/applications/editors/vscode/extensions/ms-vsliveshare-vsliveshare/default.nix - vscode-extensions.ms-vsliveshare.vsliveshare: 1.0.5043 -> 1.0.5834 #220704

cc @IvarWithoutBones @GGG-KILLER

The text was updated successfully, but these errors were encountered:

mdarocha · 2022-11-23T18:49:25Z

Also we should probably update the documentation examples to refer to newer .NET versions.

GGG-KILLER · 2022-11-23T18:54:51Z

I don't know if we should address this at the same time, but .NET 5.0 has already hit EOL and it has no warnings at all:

nixpkgs/pkgs/development/compilers/dotnet/default.nix

Line 19 in f9cdaba

dotnet_5_0 = import ./versions/5.0.nix (buildAttrs // { inherit icu; });

mdarocha · 2022-11-23T19:22:25Z

I don't know if we should address this at the same time, but .NET 5.0 has already hit EOL and it has no warnings at all:

nixpkgs/pkgs/development/compilers/dotnet/default.nix

Line 19 in f9cdaba

dotnet_5_0 = import ./versions/5.0.nix (buildAttrs // { inherit icu; });

See #173115 :)

GGG-KILLER · 2022-11-23T19:23:29Z

Have checked the listed packages that depend on .NET Core 3.1:

wasabibackend: if we update it, we'll be able to move it to .NET 6.0
alttpr-opentracker: if we update it, we'll be able to move it to .NET 6.0
baget: still on .NET Core 3.1 on source (will block full removal, we'll probably need to mark .NET Core 3.1 with a warning as deprecated or get rid of this package)
azure-functions-core-tools: if we update it, we'll be able to move it to .NET 6.0 (partially in progress at azure-functions-core-tools: 3.0.3785 -> 4.0.4736 #181126, however still using .NET Core 3.1 to run)
inklecate: if we update it, we'll be able to move it to .NET 6.0
python-language-server: repo has been archived, should be removed

mdarocha · 2022-11-23T19:27:47Z

What's the alternative to python-language-server then? I use it personally, for example.

And as for baget: is there any work done on the upstream to migrate it? Or should we remove the package as the upstream is not maintained?

I remember @IvarWithoutBones attempted to add a warning for .NET 5 in #175354 but it could not be merged, since throwing warnings caused ofborg to fail.

GGG-KILLER · 2022-11-23T19:32:35Z

What's the alternative to python-language-server then? I use it personally, for example.

And as for baget: is there any work done on the upstream to migrate it? Or should we remove the package as the upstream is not maintained?

I remember @IvarWithoutBones attempted to add a warning for .NET 5 in #175354 but it could not be merged, since throwing warnings caused ofborg to fail.

About python-language-server I don't see any alternatives, but I see it as a risk to keep any packages that still depend on .NET 3.1 as there might be security vulnerabilities in them.

As for baget, there's a PR (loic-sharma/BaGet#717) open for over 10 months with no signs of being merged. It seems the maintainer hasn't been very active as of recently so I don't think we should bet on it being merged soon.

mdarocha · 2022-11-24T23:09:33Z

wasabibackend: if we update it, we'll be able to move it to .NET 6.0 (already in progress in wasabiwallet: 2.0.1.3 -> 2.0.2 #202582)

Note that wasabibackend and wasabiwallet seem to be different packages

JamieMagee · 2023-01-01T21:44:09Z

The replacement for python-language-server is python-lsp-server.

There are currently 2 packages that depend on python-langauge-server in nixpkgs:

Both of those packages currently have upstream PRs to migrate from python-language-server to python-lsp-server:

Once those PRs are merged, and they are updated in nixpkgs, we can remove python-language-server.

JamieMagee · 2023-01-01T22:08:09Z

I attempted to updated allptr-opentracker to 1.8.5, which targets .NET 6.0, but there was an issue with the build. I opened an issue upstream: trippsc2/OpenTracker#86

JamieMagee · 2023-01-01T22:10:57Z

The upstream maintainer for baget appears to be unresponsive right now. I think we need to wait and see if a supported fork appears: loic-sharma/BaGet#717 (comment)

GGG-KILLER · 2023-01-05T22:35:21Z

The replacement for python-language-server is python-lsp-server.

There are currently 2 packages that depend on python-langauge-server in nixpkgs:

pyls-mypy

pyls-black

Both of those packages currently have upstream PRs to migrate from python-language-server to python-lsp-server:

Depend on python-lsp-server tomv564/pyls-mypy#52

Move to pylsp rupert/pyls-black#37

Once those PRs are merged, and they are updated in nixpkgs, we can remove python-language-server.

Looking into pyls-mypy and pyls-black, both seem to be unmaintained (former having the most recent commit in 2020 and latter in 2021).

Don't know if we should put much hope in having them move over to the maintained LSP.

UPDATE: Both seem to depend on palantir's language server which is Python-only, not microsoft's.

GGG-KILLER · 2023-01-06T22:09:11Z

I attempted to updated allptr-opentracker to 1.8.5, which targets .NET 6.0, but there was an issue with the build. I opened an issue upstream: trippsc2/OpenTracker#86

This is something we can solve temporarily by using dotnet sln remove in prePatch or postPatch, isn't it?

JamieMagee · 2023-01-07T00:22:04Z

This is something we can solve temporarily by using dotnet sln remove in prePatch or postPatch, isn't it?

Yeah. I was hoping for an upstream fix, but we can patch in the meantime.

JamieMagee · 2023-01-07T00:32:47Z

Looking into pyls-mypy and pyls-black, both seem to be unmaintained (former having the most recent commit in 2020 and latter in 2021).

Don't know if we should put much hope in having them move over to the maintained LSP.

UPDATE: Both seem to depend on palantir's language server which is Python-only, not microsoft's.

Lets replace them with their maintained forks

pyls-mypy with pylsp-mypy
pyls-black with python-lsp-black

Then remove python-language-server as it's unmaintained, and won't have any dependencies on it anymore.

JamieMagee · 2023-01-07T23:01:54Z

Removing python-language-server

GGG-KILLER · 2023-02-14T14:28:24Z

Update on this, it seems like the VSCode live share extension also depends on 3.1:

nixpkgs/pkgs/applications/editors/vscode/extensions/ms-vsliveshare-vsliveshare/default.nix

Lines 118 to 121 in b096dcb

  makeWrapper $PWD/dotnet_modules/vsls-agent{-wrapped,} \ 

  --prefix LD_LIBRARY_PATH : "${lib.makeLibraryPath libs}" \ 

  --set LD_PRELOAD $PWD/dotnet_modules/noop-syslog.so \ 

  --set DOTNET_ROOT ${dotnet-sdk_3}

mdarocha · 2023-02-15T11:45:24Z

Update on this, it seems like the VSCode live share extension also depends on 3.1:

nixpkgs/pkgs/applications/editors/vscode/extensions/ms-vsliveshare-vsliveshare/default.nix

Lines 118 to 121 in b096dcb

makeWrapper $PWD/dotnet_modules/vsls-agent{-wrapped,} \

--prefix LD_LIBRARY_PATH : "${lib.makeLibraryPath libs}" \

--set LD_PRELOAD $PWD/dotnet_modules/noop-syslog.so \

--set DOTNET_ROOT ${dotnet-sdk_3}

I updated the todo list. Is there an update or a replacement of that package that bumps the used dotnet version?

GGG-KILLER · 2023-02-15T11:52:53Z

I updated the todo list. Is there an update or a replacement of that package that bumps the used dotnet version?

I have downloaded the latest version of the extension and haven't found the binary being patched, I'm unsure if it is now being downloaded at runtime or if they replaced it entirely with js.

GGG-KILLER · 2023-02-17T18:39:18Z

After a quick check on the latest version of the liveshare extension, it seems like it no longer uses a .NET binary for the live share functionality and everything got reimplemented in javascript.

If someone else confirms this I think it's safe to just upgrade it and remove the .NET patching from it.

@jraygauthier and/or @deviant can you confirm this as package maintainers?

EDIT: No need for further confirmation, I've found this comment confirming it indeed got removed: microsoft/live-share#1272 (comment)

JamieMagee · 2023-02-22T05:33:26Z

That means the only remaining package to update is BaGet. What should we do? Apply patches to the existing package or migrate to the maintained fork?

mdarocha · 2023-02-22T06:58:30Z

That means the only remaining package to update is BaGet. What should we do? Apply patches to the existing package or migrate to the maintained fork?

Migrating to the fork should be fine?

GGG-KILLER · 2023-02-22T16:09:48Z

That means the only remaining package to update is BaGet. What should we do? Apply patches to the existing package or migrate to the maintained fork?

I think we could migrate to the fork. The only thing that worries me a bit are the recent commit messages but I don't know if I'm just being pedantic.

mdarocha · 2023-03-12T18:34:04Z

Unfortunately I had problems bulding the fork, I posted a comment in the PR about the issues.

GGG-KILLER · 2023-03-12T19:03:23Z

I don't know if this is the place to discuss this, but should we really replace the official package by a fork that was only made for a PR and has no issues enabled (therefore no support)?
Even more so when the official project that it's getting PR'd into seems to be dead (for the lack of a better word)?

I think a better alternative would be to remove the package while a proper fork is not found

mdarocha · 2023-03-12T19:19:25Z

That's probably the better course of action

mdarocha · 2023-03-19T11:59:12Z

I made a PR for removal of baget, after it we can remove .NET 3.1 completely from nixpkgs :)

mdarocha · 2023-03-29T14:18:04Z

And its done :)

JamieMagee · 2023-03-29T21:09:22Z

Thanks! See you all for .NET 7 EOL 😂

GGG-KILLER mentioned this issue Nov 23, 2022

azure-functions-core-tools: 3.0.3785 -> 4.0.4736 #181126

Closed

13 tasks

mdarocha mentioned this issue Dec 19, 2022

dotnet-sdk_3.1: 3.1.425 -> 3.1.426 #206765

Merged

13 tasks

JamieMagee mentioned this issue Dec 31, 2022

inklecate: 1.0.0 -> 1.1.1 #208554

Merged

13 tasks

This was referenced Jan 7, 2023

alttpr-opentracker: 1.8.2 -> 1.8.5 #209426

Closed

alttpr-opentracker: 1.8.2 -> 1.8.5 #209427

Merged

wasabibackend: 1.1.13.1 -> 2.0.2.1 #209429

Merged

mdarocha changed the title ~~dotnet 3.1 will soon be EOL~~ dotnet 3.1 isEOL Jan 7, 2023

mdarocha changed the title ~~dotnet 3.1 isEOL~~ dotnet 3.1 is EOL Jan 7, 2023

This was referenced Jan 7, 2023

python-language-server: remove #209586

Merged

azure-functions-core-tools: 4.0.4785 -> 4.0.4915 #209593

Merged

mdarocha mentioned this issue Feb 13, 2023

buildDotNet: don't pin openssl_1_1 #214843

Merged

13 tasks

mdarocha mentioned this issue Feb 18, 2023

openssl_1_1 mark as insecure/remove before 23.05 branchoff #210452

Closed

mdarocha mentioned this issue Mar 11, 2023

vscode-extensions.ms-vsliveshare.vsliveshare: 1.0.5043 -> 1.0.5834 #220704

Merged

12 tasks

mdarocha self-assigned this Mar 19, 2023

mdarocha mentioned this issue Mar 19, 2023

baget: remove due to upstream being unmaintained #222006

Merged

12 tasks

mdarocha mentioned this issue Mar 21, 2023

dotnet-sdk_3: remove #222422

Merged

12 tasks

ajs124 closed this as completed in #222422 Mar 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dotnet 3.1 is EOL #202572

dotnet 3.1 is EOL #202572

mdarocha commented Nov 23, 2022 •

edited

mdarocha commented Nov 23, 2022

GGG-KILLER commented Nov 23, 2022

mdarocha commented Nov 23, 2022

GGG-KILLER commented Nov 23, 2022 •

edited

mdarocha commented Nov 23, 2022

GGG-KILLER commented Nov 23, 2022 •

edited

mdarocha commented Nov 24, 2022

JamieMagee commented Jan 1, 2023

JamieMagee commented Jan 1, 2023

JamieMagee commented Jan 1, 2023

GGG-KILLER commented Jan 5, 2023 •

edited

GGG-KILLER commented Jan 6, 2023

JamieMagee commented Jan 7, 2023

JamieMagee commented Jan 7, 2023

JamieMagee commented Jan 7, 2023 •

edited

GGG-KILLER commented Feb 14, 2023

mdarocha commented Feb 15, 2023

GGG-KILLER commented Feb 15, 2023

GGG-KILLER commented Feb 17, 2023 •

edited

JamieMagee commented Feb 22, 2023

mdarocha commented Feb 22, 2023

GGG-KILLER commented Feb 22, 2023 •

edited

mdarocha commented Mar 12, 2023

GGG-KILLER commented Mar 12, 2023 •

edited

mdarocha commented Mar 12, 2023

mdarocha commented Mar 19, 2023

mdarocha commented Mar 29, 2023

JamieMagee commented Mar 29, 2023

dotnet 3.1 is EOL #202572

dotnet 3.1 is EOL #202572

Comments

mdarocha commented Nov 23, 2022 • edited

Issue description

Steps to reproduce

Replacing packages using dotnet-sdk_3

mdarocha commented Nov 23, 2022

GGG-KILLER commented Nov 23, 2022

mdarocha commented Nov 23, 2022

GGG-KILLER commented Nov 23, 2022 • edited

mdarocha commented Nov 23, 2022

GGG-KILLER commented Nov 23, 2022 • edited

mdarocha commented Nov 24, 2022

JamieMagee commented Jan 1, 2023

JamieMagee commented Jan 1, 2023

JamieMagee commented Jan 1, 2023

GGG-KILLER commented Jan 5, 2023 • edited

GGG-KILLER commented Jan 6, 2023

JamieMagee commented Jan 7, 2023

JamieMagee commented Jan 7, 2023

JamieMagee commented Jan 7, 2023 • edited

GGG-KILLER commented Feb 14, 2023

mdarocha commented Feb 15, 2023

GGG-KILLER commented Feb 15, 2023

GGG-KILLER commented Feb 17, 2023 • edited

JamieMagee commented Feb 22, 2023

mdarocha commented Feb 22, 2023

GGG-KILLER commented Feb 22, 2023 • edited

mdarocha commented Mar 12, 2023

GGG-KILLER commented Mar 12, 2023 • edited

mdarocha commented Mar 12, 2023

mdarocha commented Mar 19, 2023

mdarocha commented Mar 29, 2023

JamieMagee commented Mar 29, 2023

mdarocha commented Nov 23, 2022 •

edited

Replacing packages using `dotnet-sdk_3`

GGG-KILLER commented Nov 23, 2022 •

edited

GGG-KILLER commented Nov 23, 2022 •

edited

GGG-KILLER commented Jan 5, 2023 •

edited

JamieMagee commented Jan 7, 2023 •

edited

GGG-KILLER commented Feb 17, 2023 •

edited

GGG-KILLER commented Feb 22, 2023 •

edited

GGG-KILLER commented Mar 12, 2023 •

edited