Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make team member links distinguishable by an Icon #1403

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make team member links distinguishable by an Icon #1403

wants to merge 2 commits into from

Conversation

albertchae
Copy link
Contributor

@albertchae albertchae commented Apr 24, 2024 •
edited

Closes #1336

  • Display github/discourse icons next to member links
  • Need to set inline-block to display the icons inline without unnecessary line breaks
  • Moved title higher and added line breaks in between name and links to better accommodate multiple links
  • Also added some github examples for the marketing team so we can see what it looks like if there are both

image
image

@albertchae
Display github/discourse icons next to member links
901acd4 
Need to use inline-block to prevent these from causing unnecessary line breaks
@albertchae
Add some github examples in marketing team, rest of teams should be f…
f70d19f 
…illed out in a follow up
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://66291aaafdf1a700a2565a7b--nixos-homepage.netlify.app

@albertchae albertchae marked this pull request as ready for review April 24, 2024 14:44
@albertchae
Copy link
Contributor Author

Discussed in marketing meeting: @garbas suggested using only the icon instead of handle, and go back to inlining after name

@thilobillerbeck
Copy link
Collaborator

Discussed in marketing meeting: @garbas suggested using only the icon instead of handle, and go back to inlining after name

sounds like a good idea, maybe we can even think of including a popover if people want to have the name on the site directly

@djacu djacu self-requested a review April 26, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas Awaiting requested review from garbas

@thilobillerbeck thilobillerbeck Awaiting requested review from thilobillerbeck

@djacu djacu Awaiting requested review from djacu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make team member links distinguishable by an Icon
2 participants
@albertchae @thilobillerbeck