-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage of scikit-surprise as a dynamic dependency is not possible #443
Comments
I'm not sure what you mean by that? What is non-standard about the PATH here?
Unfortunately we still need |
Description
I need to be able to dynamically add/remove scikit-surprise (installed in advance somewhere else than in my
venv
) to/from my PATH to perform some processing. This cannot be done because of the__version_
variable defined here https://github.com/NicolasHug/Surprise/blob/master/surprise/__init__.py#L50The
pkg_resource
does not play well with non-standard PATH apparently. The only place where this variable is used is in__main__.py
, so a simple fix is to move it there, so that we can import thesurprise
module without any issue.Expected Results
import surprise
should just work, even if it was installed on another PATH and added dynamically.Actual Results
Versions
surprise 1.1.3 but there is a circular import issue too ...
The text was updated successfully, but these errors were encountered: