Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't keep a thread running in IncrementalArrayData #28

Open
BenTilbrook opened this issue Jul 11, 2016 · 0 comments
Open

Don't keep a thread running in IncrementalArrayData #28

BenTilbrook opened this issue Jul 11, 2016 · 0 comments

Comments

@BenTilbrook
Copy link
Collaborator

IncrementalArrayData keeps a Thread open until it's loaded all increments. This can be a problem if the IncrementalArrayData appears in a nested PowerAdapter structure, because there's no robust way to close the Data instance and stop the Thread.

Perhaps use an ExecutorService instead, such that each increment is a separate task. This would mean the IncrementalArrayData won't strictly need to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant