Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extras_require for tracing dependencies? #1812

Open
chriselion opened this issue Apr 25, 2024 · 0 comments
Open

Update extras_require for tracing dependencies? #1812

chriselion opened this issue Apr 25, 2024 · 0 comments

Comments

@chriselion
Copy link

From the 2.10.4 release notes:

Some additional dependencies are required for the tracing functionality in the execution environment. These can be installed in the base Docker image, or supplied through a conda environment. The relevant packages are
opentelemetry-sdk, opentelemetry-api, opentelemetry-instrumentation, opentelemetry-instrumentation-requests
and depending on your endpoint, either opentelemetry-exporter-otlp or opentelemetry-exporter-zipkin

Would it be possible to add these to the extras_require section of setup.py? That would let a user do something like pip install metaflow[tracing-otel], and it also makes things a lot easier for tools that build lockfiles (for example pip-tools) to understand the transitive dependencies.

If you think this is a worthwhile change, I'll submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant