Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Passing an S3PutObject to s3.put_files treated as tuple of key path values. #1805

Closed
narayanacharya6 opened this issue Apr 19, 2024 · 0 comments

Comments

@narayanacharya6
Copy link
Contributor

Because S3PutObject is a named tuple, the else branch of this if statement is never hit, irrespective of user passing Tuple[str, PutValue] or S3PutObject.

if isinstance(key_path, tuple):

If you pass an S3PutObject that has path set and not value then the put_files method is unable to resolve the file to upload because in line

https://github.com/Netflix/metaflow/blob/5908c4e1481c15a93ec5ef845cec630c4ef84919/metaflow/plugins/datatools/s3/s3.py#L1324C21-L1324C39

path = key_path[1] resolve to path to None and it can no longer find the file.

narayanacharya6 added a commit to narayanacharya6/metaflow that referenced this issue Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants