Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make default kubernetes resources configurable #1769

Closed
martinhausio opened this issue Mar 20, 2024 · 2 comments · Fixed by #1800
Closed

Make default kubernetes resources configurable #1769

martinhausio opened this issue Mar 20, 2024 · 2 comments · Fixed by #1800

Comments

@martinhausio
Copy link
Contributor

We recently upgraded our GKE Autopilot cluster to 1.29 and to our surprise, it is no longer calculating the resource allocation the same way, and the default metaflow resources are now "just a little" too large, resulting in our workflows being rejected.

I found the defaults are configured here, and we also have many ways to configure the resources, but it would be ideal for us to be able to configure the default resources via an environment variable, much the same way we can set the nodeSelector.
@savingoyal
Copy link
Collaborator

Great idea! We would be open to a PR if you would like to submit one!

@martinhausio martinhausio mentioned this issue Apr 11, 2024
Merged
@martinhausio
Copy link
Contributor Author

@savingoyal , I just submitted a quick PR for it! Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Kubernetes default resources configurable martinhausio/metaflow
2 participants
@savingoyal @martinhausio