Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of reserved parameter names #1753

Open
saikonen opened this issue Feb 23, 2024 · 0 comments
Open

Reduce the number of reserved parameter names #1753

saikonen opened this issue Feb 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@saikonen
Copy link
Collaborator

Related to the bug fix in #1736 it would be worth considering to reduce the number of reserved parameter names.

One possible approach is to prefix the internal arguments with _ to avoid the collisions with user defined parameters. The main concern with this is that it can lead to some odd UX specifically with the case of tags. If tags stops being a reserved parameter, a user can define one and then run a flow with

python CustomTagFlow.py run --tag this-is-an-internal-metaflow-tag --tags user-defined-parameter-value

which at first glance can be extremely confusing. Other edge cases might also exist.

@saikonen saikonen added the enhancement New feature or request label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant