Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile warnings in mantis-server-worker module #394

Open
liuml07 opened this issue Mar 29, 2023 · 1 comment · May be fixed by #423
Open

Fix compile warnings in mantis-server-worker module #394

liuml07 opened this issue Mar 29, 2023 · 1 comment · May be fixed by #423
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@liuml07
Copy link
Contributor

liuml07 commented Mar 29, 2023

There are compile warnings in the code due to:

  • deprecated APIs
  • missing @Nullable/@NotNull annotations
  • incomplete javadocs
  • lambda can be replaced with method references
  • raw usage of generic types
  • unnecessary type parameters (like Map<String> m = new HashMap<String>())
  • anonymous class can be replaced with lambdas
  • ... and more.

We don't need to solve all of them, but a good coding exercise is to address most those compile warnings when possible. Guidelines are:

  1. Not change code logic, which should be addressed and filed PR separately
  2. Not change public interfaces (class, methods and fields) that would break other modules or applications. But it's safe to rename private fields or methods when necessary.
  3. Prefer readability to more concise code
  4. Improve tests in the module is welcome but not required
  5. Compile and pass all existing tests.

This tracks the effort for the mantis-server-worker module to make the code change scoped.

@liuml07 liuml07 added enhancement New feature or request good first issue Good for newcomers labels Mar 29, 2023
@SalmaAfifi
Copy link

Hi @liuml07 can you please assign this task to me?

@SalmaAfifi SalmaAfifi linked a pull request Apr 18, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants