Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile warnings in mantis-control-plane-client module #421

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix compile warnings in mantis-control-plane-client module #421

wants to merge 2 commits into from

Conversation

mabelbot
Copy link

@mabelbot mabelbot commented Apr 16, 2023 •
edited

Context

Contains changes to resolve #389

Deprecation Warnings addressed (to be reviewed):

  • HttpUtility.java:63: warning: [deprecation] getUri() in HttpRequest has been deprecated
  • MantisMasterClientApi.java:778: warning: [deprecation] JsonCodec(Class) in JsonCodec has been deprecated

Progress:

  • Remove deprecated getUri() and replace with uri()
  • Remove deprecated JsonCodec constructor and replace with JacksonCodecs (as indicated in javadoc) pojo method

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

@mabelbot mabelbot had a problem deploying to Integrate Pull Request April 16, 2023 00:51 — with GitHub Actions Failure
@mabelbot mabelbot mentioned this pull request Apr 16, 2023
Open
liuml07
liuml07 requested changes Apr 22, 2023
View reviewed changes
Copy link
Contributor

@liuml07 liuml07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to take care all classes in the module? Ideally we can consolidate a single PR to address most of the compiler warnings. For e.g. in MantisMasterClientApi I can see multiple ones open.

You can also check code warnings in IntelliJ IDE editor (open a .java file and check yellow marks on the right).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuml07 liuml07 liuml07 requested changes

@nickmahilani nickmahilani Awaiting requested review from nickmahilani

@jeffchao jeffchao Awaiting requested review from jeffchao

@piygoyal piygoyal Awaiting requested review from piygoyal

@calvin681 calvin681 Awaiting requested review from calvin681 calvin681 is a code owner

@sundargates sundargates Awaiting requested review from sundargates sundargates is a code owner

@Andyz26 Andyz26 Awaiting requested review from Andyz26 Andyz26 is a code owner

@hmitnflx hmitnflx Awaiting requested review from hmitnflx hmitnflx is a code owner

@markcho markcho Awaiting requested review from markcho

@fdc-ntflx fdc-ntflx Awaiting requested review from fdc-ntflx fdc-ntflx is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix compile warnings in mantis-control-plane-client module
2 participants
@mabelbot @liuml07