Upgrade JUnit4 to Junit5 #372
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypherean
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
cypherean
force-pushed
the
upgrade_junit
branch
from
b0ad12b
to
fe2b19e
Compare
cypherean
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
|
Is this ready for review? |
|
Not yet, there's a minor issue with one of the submodules that I'm trying to fix |
|
Update @sundargates : I've been trying to resolve this for quite some time. Can you help me with the same? |
cypherean
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
cypherean
force-pushed
the
upgrade_junit
branch
from
1ed8206
to
c789321
Compare
cypherean
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Upgrade mockito in mantis-server-worker
cypherean
force-pushed
the
upgrade_junit
branch
from
c789321
to
cd200f6
Compare
cypherean
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
cypherean
requested review from
nickmahilani,
jeffchao,
piygoyal,
calvin681,
sundargates,
Andyz26,
hmitnflx,
markcho,
liuml07 and
fdc-ntflx
as code owners
|
@sundargates following our conversation during office hours, I've left |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Upgrades JUnit4 to JUnit5.
Fixes #369
Doesn't upgrade
mantis-control-plane-serverdue to issues with akka packageChecklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests