Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning required for cloudflare in requirements.txt - urgent #4843

Open
mahtin opened this issue May 10, 2024 · 3 comments
Open

Pinning required for cloudflare in requirements.txt - urgent #4843

mahtin opened this issue May 10, 2024 · 3 comments

Comments

@mahtin
Copy link

mahtin commented May 10, 2024

The code creating requirements.txt needs updating to cloudflare<=2.19.*. This is explained at github.com/cloudflare/python-cloudflare README file. It's become kinda urgent because of a pending 3.x release that's not code compatible. This code will continue to be 100% compatible with the 2.19.* releases.

@hosseinsh
Copy link
Contributor

Hi @mahtin, thanks for bringing this to our attention, I believe this should not impact Lemur, since we are already pinning to the 2.19.2 version:

cloudflare==2.19.2

@mahtin
Copy link
Author

mahtin commented May 11, 2024

Thanks @hosseinsh for noting all that. I didn't see where the pinning was done in this package (maybe I should look further).

I'd still recommend 2.19.* as your pinning just in case there's any other future fixes. That said, whatever you choose, that good as long as it's pinned.

@mahtin
Copy link
Author

mahtin commented May 11, 2024

Ok. That's solved. It's requirements.in (and its variants) that need:

cloudflare<=2.19.*

The present file(s) do not pin a value. Note that the file(s) presently have CloudFlare; but pip is case insensitive [1].

[1] https://peps.python.org/pep-0426/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants