Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: @DgsData should be @Repeatable #1193

Closed
xenoterracide opened this issue Aug 19, 2022 · 1 comment · May be fixed by Netflix/dgs#121
Closed

feature: @DgsData should be @Repeatable #1193

xenoterracide opened this issue Aug 19, 2022 · 1 comment · May be fixed by Netflix/dgs#121
Labels
enhancement New feature or request

Comments

@xenoterracide
Copy link

https://netflix.github.io/dgs/datafetching/#multiple-dgsdata-annotations-via-dgsdatalist

@DgsData.List({
    @DgsData(parentType = "Query", field = "movies"),
    @DgsData(parentType = "Query", field = "shows")
})

couldn't @DgsData have @Repeatable?
@xenoterracide xenoterracide added the enhancement New feature or request label Aug 19, 2022
@xenoterracide xenoterracide changed the title feature: feature: @DgsData should be @Repeatable Aug 19, 2022
detinho added a commit to detinho/dgs that referenced this issue Nov 14, 2022
@detinho
Update datafetching.md
7b2cebd 
Documenting that `@DgsData` is repeatable.
Fixes: Netflix/dgs-framework#1193
@detinho detinho mentioned this issue Nov 14, 2022
Open
@detinho
Copy link

detinho commented Nov 14, 2022 •
edited

It seems it already is a repeating annotation.

Opened a PR Netflix/dgs#121 to update the docs.

@Emily Emily closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Documenting that @DgsData is repeatable. detinho/dgs
3 participants
@xenoterracide @Emily @detinho