Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor buttons to follow OOTB behavior #159

Open
1 task
Gonzalo-CG opened this issue Nov 6, 2023 · 4 comments
Open
1 task

Refactor buttons to follow OOTB behavior #159

Gonzalo-CG opened this issue Nov 6, 2023 · 4 comments

Comments

@Gonzalo-CG
Copy link
Collaborator

Business value

As a content author/editor, I want a clear and standardized way to choose the styling of buttons across all blocks and pages.

Description

The current implementation of blocks has button styling defined by the order buttons are placed, i.e. when there are 2 buttons one below the other, the 2nd one is treated as a secondary button.

This implementation needs to be changed to align with the OOTB Franklin behavior, where variations of buttons are defined by the emphasis of the text in the Word document (e.g. bold or italic).

Acceptance Criteria

  • Button styling is dictated by the emphasis of the text in the Word document (e.g. bold, italic, underline, etc.) rather than the placement of the buttons.

Notes

Franklin OOTB Buttons docs

@Gonzalo-CG Gonzalo-CG added the Enhancement New feature or request label Nov 6, 2023
@Gonzalo-CG
Copy link
Collaborator Author

This issue will be solved in conjunction with #115

@DanielaPedrochevd
Copy link
Collaborator

DanielaPedrochevd commented Nov 14, 2023

We cannot deliver this button. After further investigation on Mack trucks delivery, we consider that due to the personalization of the buttons, editing the behavior may bring some issues. Therefore, I will put it to the backlog until we can pick it up again.

@mollyaljenkins
Copy link
Collaborator

This ticket is on hold until the end of the redesign due to code changes needed for the button that would conflict with the changes needed for redesign.

@shirin27
Copy link
Collaborator

Kamino cloned this issue to hlxsites/vg-macktrucks-com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants