Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: video in hero #151

Open
cogniSyb opened this issue Oct 25, 2023 · 3 comments
Open

FR: video in hero #151

cogniSyb opened this issue Oct 25, 2023 · 3 comments

Comments

@cogniSyb
Copy link
Collaborator

cogniSyb commented Oct 25, 2023

Agile Requirement
As a business owner I want to have a Hero block that will autoplay video content, which includes a pause button, so that users have the ability to let the video play while they interact with the page or stop it if they want to.

Acceptance Criteria
Hero block

  • The Hero block contains a video background that autoplays when a user enters the page
  • A pause button is located at the top right corner overlapping the media content of the hero block and is visible the entire time

Pause button

  • The button must be discernible from other controls and be clearly labeled and icon that indicates its functionality
  • The pause/play button should be accessible to users navigating via keyboard, meaning it should be focusable and actionable using keyboard inputs. The focus style should be the same as for the scroll to top button
  • Upon pressing the pause button, the autoplay video should immediately stop playing
  • Once the video is paused, the [pause button should change to a play button]

(https://www.figma.com/file/Id3nd9kbfh8TpS1SfWhrW2/Volvo-Component-Library?type=design&node-id=566-2770&mode=dev)

Questions

Notes

image

image

Previous notes:

Extend the hero by allowing an autoplay video as well for the hero.

Pause button to be created, see Netcentric/vg-volvotrucks-us-rd#156.
Blocks with an autoplay video should have a pause button, to comply with accessibility standards. Specifically, we’re mitigating Failure 93 of Success Criterion 1.4.2.

Designs have been adjusted to show a pause button. For now, we’re focusing on the hero Netcentric/vg-volvotrucks-us-rd#41, the design is available.

The video player for autoplay videos should have a visible pause button when the video starts playing
The button must be discernible from other controls and be clearly labeled and icon that indicates its functionality
The pause/play button should be accessible to users navigating via keyboard, meaning it should be focusable and actionable using keyboard inputs. The focus style should be the same as for the scroll to top button
Upon pressing the pause button, the autoplay video should immediately stop playing
Once the video is paused, the pause button should change to a play button
The button should be large enough to be easily tapped on touch devices without accidentally pressing adjacent controls

@DanielaPedrochevd DanielaPedrochevd added this to the MT PDP milestone Oct 31, 2023
@BeckyMedlin
Copy link
Collaborator

@cogniSyb Is this considered an enhancement?

@cogniSyb cogniSyb added the Enhancement New feature or request label Oct 31, 2023
@cogniSyb
Copy link
Collaborator Author

Yes @BeckyMedlin, this came out of a call recently with business and design.

@shirin27
Copy link
Collaborator

Kamino cloned this issue to hlxsites/vg-macktrucks-com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants