Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: MT Solutions Engine Row columns variant #137

Open
DanielaPedrochevd opened this issue Oct 23, 2023 · 6 comments
Open

FR: MT Solutions Engine Row columns variant #137

DanielaPedrochevd opened this issue Oct 23, 2023 · 6 comments

Comments

@DanielaPedrochevd
Copy link
Collaborator

DanielaPedrochevd commented Oct 23, 2023

Agile Requirement
As a business owner, I want to display different engines in a list form as in the design -> https://www.figma.com/file/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?type=design&node-id=1968-227762&mode=dev

It’s related to #55; the All Trucks page.

Description:

  • three background colour states
    • row dark
    • row light
    • row hover
  • Image is to the left, hovering over dots background image
  • Text elements to the right
    • Title, details of product, 'explore' button
  • Explore button can be primary buttons as in All Trucks

Solutioning
Existing code should be refactored a bit to reuse the same block on both pages.

  • Rename block from v2-all-trucks to something more generic, v2-product-listing
    • Renaming block would entail also to rename variables and classnames (like truckElement, truckImageWrapper v2-all-trucks__truck-image)
  • Functionality for filtering should only be executed when the variant with-filter is applied to the block.
  • When hovering the product image, white background should show
  • When hovering the primary button, the product background image and white background should show

Image

@DanielaPedrochevd
Copy link
Collaborator Author

propose design change to use the same solution #136

@DanielaPedrochevd DanielaPedrochevd added this to the MT Solutions milestone Oct 31, 2023
@DanielaPedrochevd DanielaPedrochevd changed the title FR: MT Solutions Engine Row FR: MT Solutions Engine Row columns variant Jan 3, 2024
@DanielaPedrochevd DanielaPedrochevd added the Design Question RE/Dev team has open questions regarding the designs. label Jan 3, 2024
@cogniSyb
Copy link
Collaborator

Questions:

  • Secondary buttons are used in this listing, could we make them primary, as in All Trucks?
  • GT America is used in the headings. in All Trucks Helvetica Neue LT Pro is being used. On both pages these headings will be H2 level. Could we change the headings in All Trucks to GT America?

@DanielaPedrochevd
Copy link
Collaborator Author

@WendyKruger can you answer Syb's questions please?

@cogniSyb
Copy link
Collaborator

cogniSyb commented Feb 6, 2024

  • Secondary buttons are used in this listing, could we make them primary, as in All Trucks?
  • GT America is used in the headings. in All Trucks Helvetica Neue LT Pro is being used. On both pages these headings will be H2 level. Could we change the headings in All Trucks to GT America?

Questions have been answered with a 'yes' during the last meeting

@shirin27 shirin27 removed the Design Question RE/Dev team has open questions regarding the designs. label Feb 6, 2024
@mollyaljenkins
Copy link
Collaborator

  • Ability to show block without filtering (the block on diesel engines page doesn’t filter)
  • Should be able to include v2-pencil-promo, FR: Pencil Promo block #108 (as per design)
    • Filtering interaction should work on the pencil-promo block that is included

Zoe to work with Wendy to create this ticket

@shirin27
Copy link
Collaborator

Kamino cloned this issue to hlxsites/vg-macktrucks-com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants