Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CSS styling option on Images & Banner Style color change #285

Closed
3 tasks done
NCalexiaeche opened this issue Feb 10, 2023 · 9 comments · Fixed by #315 · May be fixed by #293
Closed
3 tasks done

New CSS styling option on Images & Banner Style color change #285

NCalexiaeche opened this issue Feb 10, 2023 · 9 comments · Fixed by #315 · May be fixed by #293
Assignees
Labels
frontend UI and block related

Comments

@NCalexiaeche
Copy link
Collaborator

NCalexiaeche commented Feb 10, 2023

Acceptance Criteria:

  • Remove darkening filter on
  • Enable colors settings on components background (ex: Social media cards)
  • Enable colors settings on (Cards) components for titles, subtitles and body text to white when background colours are medium or dark.

Screenshot 2023-02-10 at 14 38 51

Screenshot 2023-02-10 at 14 39 46

@NCalexiaeche
Copy link
Collaborator Author

Change text color to white. Replace the background color #6AA2DC (because it doesn't passes accesiibility) for #2E308E

@NCalexiaeche
Copy link
Collaborator Author

@jonatan-lledo-netcentric Let's make sure we cover all the different colors from the brand guidelines : https://expertise.netcentric.biz/cognizant-netcentric-brand-guidelines#home

@pedrogbot
Copy link
Collaborator

pedrogbot commented Feb 21, 2023

The following functionalities have been tested on this ticket:

  • Enable colours settings on components background (ex: Social media cards) -> Working as expected
  • Enable colours settings on (Cards) components for titles, subtitles and body text to white when background colours are medium or dark -> Working as expected
  • Darkening Filter -> When the background used in this component is a photo, the 110% brightness makes the texts unreadable and the images do not look good. In addition, this component is often used on the website with different colours, so the change in brightness affects them differently depending on the colour used. When hovering over the component, it looks even worse.

Please find attached some of the pages where the affected component is used and you can see the behaviour, on the left side the page in production and on the right side how it looks with the new changes in the branch.

image

image

image

image

image

image

When the behaviour of the brightness filter component is decided, all functionalities will be reviewed again.

@pedrogbot
Copy link
Collaborator

As we have discussed on the slack channel, by applying the same component on photos and colours it will work on colours but on photos it will look too bright and the text will not be legible, we should apply one solution for colours (which is the new brightness that is being developed) and create a new flavour for images, so they look correctly

@NCalexiaeche
Copy link
Collaborator Author

Please use those colors in the banners @sonaldhekale
Screenshot 2023-03-16 at 08 57 29
Screenshot 2023-03-16 at 08 58 22

@NCalexiaeche NCalexiaeche changed the title New CSS styling option on Cards New CSS styling option on Images & Banner Style color change Apr 4, 2023
@NCalexiaeche
Copy link
Collaborator Author

NCalexiaeche commented Apr 4, 2023

This ticket is only looking at:

Another ticket will be created to change the cards from images to a specific background black that need to be created.

@DaphneKoren
Copy link
Collaborator

@DaphneKoren
Copy link
Collaborator

The following tickets were created for the cards
#321
#323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment