-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppCache events only fire once #210
Comments
I see, thank for reporting it. PR is welcome to fix that (since you already figured out what the code does). |
I'll take a look this weekend at how to get the options into the templated
manifest.html code and then submit a PR.
On Tue, Mar 21, 2017, 19:06 Arthur Stolyar ***@***.***> wrote:
I see, thank for reporting it. PR is welcome to fix that (since you
already figured out what the code does).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#210 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6KGcV2U41a_dKb7LgGUyTZ7da4bHsdks5roFfagaJpZM4MkYiY>
.
--
Kevin James
|
@enzoaeneas okay, thank you! Feel free to ask questions if something won't be clear. |
IMHO that 5000 ms timeout effectively prevents any Application Cache events after 5000ms. So, if the application takes longer than 5 seconds to download, no
Unfortunately Application Cache is still very important for PWAs, because not all browsers support Service Workers, yet... |
…n't unregister events after 5000ms potential fix for NekR#210
Wow. It's been a month since I looked at this. I'll work on the
pull-request and get it submitted :-P
On Tue, Apr 25, 2017 at 4:22 PM jampy ***@***.***> wrote:
IMHO that 5000 ms timeout effectively prevents *any* Application Cache
events after 5000ms. So, if the application takes longer than 5 seconds to
download, no UpdateReady is ever fired.
- what's the point in cleaning up anyway? It obviously makes sense to
stop that 50ms interval, but why run also removeEventListener? I guess
those three event listeners takes up less space in memory than the code
that removes them. ;-)
- why is the interval needed? Looks like a polyfill or something
similar. Are there browsers that don't provide event listeners for
application cache?
Unfortunately Application Cache is still very important for PWAs, because
not all browsers support Service Workers, yet...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#210 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6KGX07oa-3ZXVj5na96Zk0VDzuYnWgks5rzlYWgaJpZM4MkYiY>
.
--
Kevin James
|
@enzoaeneas There is already a PR, see: #241 |
@enzoaeneas: do you have a chance to test #248? |
Let me see if I can get to it today. I'm working on a different projec
nowt, but I am still primary on the other. I test in Chrome latest and IE
11. I *may *be able to get Safari.
On Wed, May 3, 2017 at 1:36 AM jampy ***@***.***> wrote:
@enzoaeneas <https://github.com/enzoaeneas>: do you have a chance to test
#248 <#248>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#210 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6KGVLPoUTq_28xQ9HOl5deng6J9Saxks5r2BJ4gaJpZM4MkYiY>
.
--
Kevin James
|
I found some of my notes regarding AppCache statuses/events (on macOS) (posting here instead of in the #248 PR to be to find it easier):
|
That one excludes IE/Edge, but AFAIR it has similar to Chrome events/statuses, I just didn't test it a lot in IE/Edge. |
@NekR: completely missed this since I was waiting for a reply in the PR. Anyway, could you please explain what this stuff means? Thanks. |
The code within manifest.html removes the events after five seconds (cleanuptimer) and does not reattch them. My application may be updated at anytime while the browser is running, and I need to notify my users that an update is ready.
Currently events will only fire when the application is loaded.
The text was updated successfully, but these errors were encountered: