Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured tokenizer order is different from documentation #169

Open
mister-magpie opened this issue May 15, 2024 · 2 comments
Open

Structured tokenizer order is different from documentation #169

mister-magpie opened this issue May 15, 2024 · 2 comments

Comments

@mister-magpie
Copy link

I am using the Structured tokenizer for a project and I noticed that encoded files follow the order:
Timeshift, Pitch, Velocity, Duration

In the docs however it indicates that the timeshift token should be at the end.
Is this on purpose or is it bug? In the first case I think the documentation should be updated accordingly.

@Natooz
Copy link
Owner

Natooz commented May 15, 2024

Thank you for the note.
For structured, the type of the first token (TimeShift of Pitch) isn't really important. If it starts with a Pitch, this means that a the original music file contains a note at the very beginning (tick 0), whereas if it begins with a TimeShift, this means that the first note is actually played after certain period of time (hence time shift).
I hope this cleared things up! 🙌

Copy link

github-actions bot commented Jun 6, 2024

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added stale Inactive since 30 days or more and removed stale Inactive since 30 days or more labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants