Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ns tries to connect to Google Analytics even when statistics collection permission is denied #5746

Open
3 tasks done
unikitty37 opened this issue Jul 3, 2023 · 1 comment
Labels

Comments

@unikitty37
Copy link

Issue Description

When I say "no" to anonymous statistics collection on first run, ns still tries to make a connection to google-analytics.com.

I would not expect any connection to be made to an analytics company when I have denied permission for the program to do so.

(I also think the prompt should say who you are using for analytics — I would probably say "yes" to a self-hosted solution, but "no" to Google, as the data is almost certainly anonymous to you, but not to them. There is, after all, a reason they're letting you use Analytics for free — and the price is my data :)

Reproduction

  1. Install a connection monitoring program like Little Snitch, and configure it to ask permission for each connection.
  2. npm i -g nativescript
  3. ns
  4. Answer n to the anonymous statistics prompt.
  5. Little Snitch will prompt for permission to connect to various sites; one of these will be google-analytics.com.

Relevant log output (if applicable)

No response

Environment

OS: macOS 13.4.1
CPU: (10) arm64 Apple M1 Max
Shell: /bin/zsh
node: 20.3.1
npm: 9.6.7
nativescript: 8.5.3

# android
java: 19.0.2
ndk: Not Found
apis: Not Found
build_tools: Not Found
system_images: Not Found

# ios
xcode: 14.3.1/14E300c
cocoapods: Not Found
python: Not Found
python3: 3.11.3
ruby: 3.2.2
platforms: 
  - DriverKit 22.4
  - iOS 16.4
  - macOS 13.3
  - tvOS 16.4
  - watchOS 9.4

Dependencies

"dependencies": {},
"devDependencies": {}

Please accept these terms

@unikitty37 unikitty37 added the bug-pending-triage Reported bug, pending triage to confirm. label Jul 3, 2023
@rigor789 rigor789 transferred this issue from NativeScript/NativeScript Jul 6, 2023
@rigor789
Copy link
Member

rigor789 commented Jul 6, 2023

I believe this is "working as intended" based on the code here:

const message = `Do you want to help us improve ${this.$analyticsSettingsService.getClientName()} by automatically sending anonymous usage statistics? We will not use this information to identify or contact you.`;
trackFeatureUsage = await this.$prompter.confirm(message, () => true);
await this.setStatus(
this.$staticConfig.TRACK_FEATURE_USAGE_SETTING_NAME,
trackFeatureUsage
);
await this.trackAcceptFeatureUsage({
acceptTrackFeatureUsage: trackFeatureUsage,
});

However I do agree, if the answer is n/no then nothing should be tracked at all, so I'm marking it as a bug.

If I understand the code correctly, it only sends a single event with the no choice after which no further events are ever sent (hopefully).

@rigor789 rigor789 added bug and removed bug-pending-triage Reported bug, pending triage to confirm. labels Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants