Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation and nested page-router-outlet with lazy loaded children #57

Open
fpaaske opened this issue Feb 15, 2022 · 4 comments
Open

Navigation and nested page-router-outlet with lazy loaded children #57

fpaaske opened this issue Feb 15, 2022 · 4 comments

Comments

@fpaaske
Copy link

fpaaske commented Feb 15, 2022

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 8.1.5
  • Cross-platform modules: 8.1.5
  • Android Runtime: 8.1.0
  • iOS Runtime: 8.1.1
  • Plugin(s): "@nativescript-community/ui-material-bottom-navigation": "~6.2.13"
  • NativeScript-Angular: 13.0.2
  • Angular: 13.1.1

Describe the bug

Navigation for a page-router-outlet is not working anymore after navigating back from details view.

I have a navigation setup with nested page-router-outlets, much like this example, except the children (player details and team details) are also lazy loaded modules with their own routes.

After starting the app, and the tabs are loaded with their lazy loaded module, I can navigate to the details view and back. However, when I try to navigate to the details view again, there's no response. I have enabled tracing on the router, and there are no events fired when navigating back. Also no events are fired on new navigation attempts.

If I navigate to another tab, I can repeat the process. Then that will be "stuck" as well.

To Reproduce
Use the example from the link above and lazy load the details components.

Expected behavior
Navigation should keep working regardless of lazy loaded children.

Sample project

Additional context

This was working in @nativescript/angular 13.0.1, but then with issues like #49 and #53

@jessorlisa
Copy link

jessorlisa commented Feb 16, 2022

@nativescript/[email protected] breaks the back navigation for me as well, even without nested page-router-outlets.

@edusperoni @NathanWalker
Let me know if you need a sample project for reproduction.

@13dante04
Copy link

I can also confirm that it broke the navigation for me to on 13.0.2, also without nested router-outlets, downgrading to @13.0.1 fixed the issue for me.

@edusperoni
Copy link
Collaborator

Please provide an example project of the behavior so I can take a look. Unfortunately I haven't run into this issue on any of my apps.

@jessorlisa
Copy link

@edusperoni I assume @jcassidyav's sample was sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants