-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Named Outlet non responsive after clearHistory
navigation
#39
Comments
@wSedlacek: What puzzles me is that I don't get the same behaviour in this app I've got the above in (a more complex setting) in two apps, and in one of them I get the error, where the router just does not respond after doing a I did try the fix in PR #38 on my large project that has the issue, and that, unfortunately, does not change anything. |
I'll try to get this fired up on an iOS simulator and see what happens. |
Hm, I've tried rolling back to Angular 11 (11.2.14) + NS Angular 11.8.0 and do also get this issue in my "complex" app (all routing just stops - only .back() and tab changes work). |
Just a side note: Running with HMR on Android, I get this crash when doing code changes using PR 38
which is this line from the PR:
|
@timdoege I have updated my PR to account for the response being
I attempted to get this repo running but I did not have any luck. I did test the behavior on iOS now though, in the template app. Do you have an example app with NativeScript 8+ that doesn't work with these changes that I can debug against? |
@wSedlacek Great - I will give your update a spin this week, thanks. Regarding repo the https://github.com/NativeScript/login-tab-navigation-ng NativeScript/login-tab-navigation-ng#21 which moves it to NS 8.1 / Angular 12 (and MD bottom navigation). |
Thank you. I will give NativeScript/login-tab-navigation-ng#21 a shot. |
Environment
Provide version numbers for the following components (information can be retrieved by running
tns info
in your project folder or by inspecting thepackage.json
of the project):Describe the bug
When navigating to a nested route (one with a named outlet) after a
clearHistory
a navigation event would fire, but the outlet would not be updatedTo Reproduce
Clone https://github.com/herefishyfish/named-router-navigation-bug
Start Android application
Press "Go to dashboard"
Press "Nested route in navbar"
Press Notifications tab
Press Todos tab
Press "Nested route in navbar"
Expected behavior
For the second press of
Nested route in navbar
to navigate to the nested route.Sample project
https://github.com/herefishyfish/named-router-navigation-bug
Additional context
There was a few messages in Discord about this:
https://discord.com/channels/603595811204366337/606457628729671691/895530953068408894
The text was updated successfully, but these errors were encountered: