-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the mic initialization #326
Comments
I'm interested if anyone has thoughts about what parameters make sense to be passing into mic vs what can be read from profile. Are there scenarios that I'm not thinking of? |
Draft
8 tasks
Draft
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Detailed Description
Right now, the initialization of the mic object uses the following initialization:
def init(
self,
input_device,
output_device,
active_stt_reply,
active_stt_response,
passive_stt_engine,
active_stt_engine,
special_stt_slug,
plugins,
tts_engine,
vad_plugin,
keyword=['NAOMI'],
print_transcript=False,
passive_listen=False,
save_audio=False,
save_passive_audio=False,
save_active_audio=False,
save_noise=False
):
It makes sense to to me to pass in the input and output devices (this could eventually allow a multiheaded Naomi with different input/output devices in different rooms), but it seems to me like it would make more sense to read most of these directly from the profile.
Context
I am working on the populate process and wanted to create a mic for testing input and output. I had to pass a bunch of None parameters to get around all the options I hadn't configured yet and didn't need, which just seemed silly.
Possible Implementation
Your Environment
The text was updated successfully, but these errors were encountered: