Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Refine the test framework introduced in #10745 #10850

Closed
binmahone opened this issue May 21, 2024 · 2 comments · Fixed by #10861
Closed

[FEA] Refine the test framework introduced in #10745 #10850

binmahone opened this issue May 21, 2024 · 2 comments · Fixed by #10861
Assignees
Labels
feature request New feature or request

Comments

@binmahone
Copy link
Collaborator

binmahone commented May 21, 2024

some offline feedbacks of #10745 shows that:

  1. Many of the expression based suites are falling back to CPU execution even if the expression is already suppported in GPU, because RAPIDS does not support BoundReference(which UT test code will generate a lot) very well.
  2. When falling back and Vanilla Spark's whole stage code gen is enabled (By default), compilation of generated code will fail because Vanilla Spark's UT did not pass enough type information for null fields
  3. So they have to manually disable whole stage code gen to get such test case passed.

We think Item 3 is not a good idea, so we'll refine the framework to fix the root cause, i.e. Item 1 and Item 2

@binmahone binmahone added feature request New feature or request ? - Needs Triage Need team to review and classify labels May 21, 2024
@binmahone binmahone self-assigned this May 21, 2024
@jlowe
Copy link
Member

jlowe commented May 21, 2024

@binmahone can you elaborate on what this is asking for? It simply says "based on feedback of #10745," but when I go there, there's no feedback there. Thus it's not clear what this is proposing to do or how one would know a PR stating it fixes it actually fixes it.

@binmahone
Copy link
Collaborator Author

@jlowe background updated in the issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants