Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling the cuDF default pinned pool for 24.06 #10815

Closed

Conversation

abellina
Copy link
Collaborator

@abellina abellina commented May 14, 2024

Closes #10814

Depends on: rapidsai/cudf#15665 and rapidsai/cudf#15745

This PR disables a default pinned pool in cuDF since we already have one configured that is shared with cuDF and is also accessible for HostMemoryBuffer operations.

@abellina abellina added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label May 14, 2024
@abellina abellina marked this pull request as ready for review May 21, 2024 21:45
@abellina
Copy link
Collaborator Author

build

1 similar comment
@abellina
Copy link
Collaborator Author

build

@abellina abellina force-pushed the disable_default_pinned_pool branch from eec462e to 5899c89 Compare May 21, 2024 22:29
@abellina
Copy link
Collaborator Author

I tried pulling 24.06 into this but I had issues trying to fast forward there, so I ended up rebasing it (it's just 1 commit so I figured that would be OK).

@abellina
Copy link
Collaborator Author

build

@abellina
Copy link
Collaborator Author

I am going to handle this directly in cuDF JNI by rapidsai/cudf#15815. Please see that PR for more info.

I am likely to put up a documentation PR to document how the pinned pool works with different configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Use cudf::io::config_host_memory_resource
2 participants