Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing num_rollout_samples modifies the validation set in PPO #90

Open
odelalleau opened this issue Jan 23, 2024 · 0 comments
Open

Changing num_rollout_samples modifies the validation set in PPO #90

odelalleau opened this issue Jan 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@odelalleau
Copy link
Collaborator

Describe the bug

Technically this may not be a bug, but the current default config setting of model.ppo.num_val_samples (set to ${.num_rollout_samples}) makes it such that modifying num_rollout_samples will also change the validation set, which is bad as it may lead to deriving incorrect conclusions when checking the impact of modifying num_rollout_samples.

Expected behavior

The validation set should remain the same by default when modifying num_rollout_samples.

Additional context

My suggestion would be to deprecate num_val_samples and replace it with limit_val_batches (which is currently missing -- see #27)

@odelalleau odelalleau added the bug Something isn't working label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant