-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SFT val_check_interval
should accept float input
#160
Comments
AtsunoriFujita
changed the title
SFT
SFT Apr 18, 2024
limit_val_batches
should accept float input on SFTlimit_val_batches
should accept float input
AtsunoriFujita
changed the title
SFT
SFT Apr 18, 2024
limit_val_batches
should accept float inputval_check_interval
should accept float input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Unlike NeMo, the NeMo-Aligner API ignores float inputs (fraction) to
val_check_interval
.Fraction input is intuitive and should help improve UX.
Describe the solution you'd like
NeMo's implementation would be helpful. Dependencies will be looked into in the future.
The text was updated successfully, but these errors were encountered: