-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoOp scheduler claims zero-dimensional non-trivial fusions #2241
Labels
Segmentation
Issues related to nvFuser Segmentation
Comments
This is actually the intended behavior of the NoOp scheduler. We just need to be more careful to exclude ops that produce reductions to zero-dimensional outputs, like matmuls with all 1D inputs. I'll do that in #2236 and close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not sure if this is intended behavior, but it led to some small confusion leading to reordering the
ExpressionEvaluator
scheduler before NoOp in #2209. I'm posting this issue since it is confusing for a NoOp scheduler to compute an op.The following test "fails":
Even though the no-op scheduler claims the segment, it does result in a working fusion and the result is correct. Here is the kernel:
Segmenter logging doesn't seem to give any clues as to why NoOp accepts the fusion:
The text was updated successfully, but these errors were encountered: